Summary: | genkernel should check make.conf (if present) | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | Xake <kanelxake> |
Component: | genkernel | Assignee: | Gentoo Genkernel Maintainers <genkernel> |
Status: | RESOLVED INVALID | ||
Severity: | enhancement | CC: | alonbl, fmccor |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Xake
2008-04-25 21:50:05 UTC
Set PORTDIR in /etc/genkernel.conf Sorry, set DISTDIR In my world that is a workaround. I still do not see why genkernel can't fetch this by itself. But if that is the word of the devs, I think I have to live with it. Thanks anyway for the great piece that is genkernel. Because genkernel is designed to work on a non-Gentoo distro. Doing an automatic lookup would be adding portage-specific code, which is a no-no in our eyes. But then comes the problem when it relies on portage to fetch the files it needs, and to put it where it wants it. But I guess that making genkernel do that would add non-necessary things to the code, so maybe it is best as is. While genkernel is designed for use by any distribution, we only really support its use on Gentoo. We set default versions for the external packages and test only those versions. As such, we explicitly list them in the ebuild and modify the installed genkernel.conf respectively. Anyone outside of Gentoo is welcome to use any versions that they deem fit. It's up to them to put the tarballs in the correct place, in that case. If they find bugs and report them, we'll fix them, so long as the bug is not introduced by moving to an unapproved/untested version of an external package, and even then is judged on a case-by-case basis. All of that being said, I see no reason why genkernel couldn't do the following: - Check command line for setting - Check genkernel.conf for setting - Check for existence of make.conf and check for setting - Fall back to internal defaults Doing this would allow for these settings to be pulled correctly on a Gentoo machine without making Gentoo a requirement for the system. I see nothing wrong with adding small Gentoo-specific enhancements. The main concern is that we don't start pushing in too many Gentoo-specific things, causing the code to be forked internally. Adding checking of make.conf seems like a reasonable thing to do, provided that we don't *depend* on it being present. I see no problem with having make.conf variables as a lower priority than genkernel.conf or the command line, but higher than the built-in defaults. *** Bug 220111 has been marked as a duplicate of this bug. *** Per bug#220111, the gentoo DISTDIR should not be used in order to store long term sources. The genkernel ebuild should copy these sources into ROOT for genkernel use. This solves the need to lookup the /etc/make.conf and the issue of user clears the DISTDIR cache. This is no longer an issue since the final release of 3.4.10 puts the distfiles in /var/cache/genkernel/src, which is the default value. |