Bug 219092 – net-analyzer/postal-0.62 fails w/ gcc-4.3.0; bump and patch

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Peter Alfredsen (RETIRED) 2008-04-23 23:56:54 UTC]

config.status: creating Makefile
config.status: creating postal.h
config.status: creating port.h
config.status: creating postal.spec
config.status: creating sun/pkginfo
config.status: creating conf.h
config.status: conf.h is unchanged
i686-pc-linux-gnu-g++ -O2 -march=i686 -mtune=athlon-xp -msse -mmmx -pipe -ggdb3 -O2 -g -Wall -W -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Wcast-qual -Woverloaded-virtual -pedantic -ffor-scope -c expand.cpp
i686-pc-linux-gnu-g++ -O2 -march=i686 -mtune=athlon-xp -msse -mmmx -pipe -ggdb3 -O2 -g -Wall -W -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Wcast-qual -Woverloaded-virtual -pedantic -ffor-scope -c userlist.cpp
userlist.cpp: In constructor ‘UserList::UserList(const char*, const char*, bool)’:
userlist.cpp:19: error: ‘exit’ was not declared in this scope
userlist.cpp:24: error: ‘strtok’ was not declared in this scope
userlist.cpp:29: error: ‘strlen’ was not declared in this scope
userlist.cpp:41: error: ‘strlen’ was not declared in this scope
userlist.cpp:48: error: ‘exit’ was not declared in this scope
userlist.cpp: In member function ‘std::string UserList::randomUser()’:
userlist.cpp:75: error: ‘random’ was not declared in this scope
make: *** [userlist.o] Error 1
make: *** Waiting for unfinished jobs....


Reproducible: Always

Steps to Reproduce:

[Comment 1 Peter Alfredsen (RETIRED) 2008-04-23 23:58:38 UTC]

Created attachment 150767 [details, diff]
01_postal-0.69-gcc43.patch

Fixes the basic error. Though the changelog for postal 0.69 claims gcc-4.3.0 compatibility, that's not true when you play around with the configure options.

[Comment 2 Peter Alfredsen (RETIRED) 2008-04-24 00:00:38 UTC]

Created attachment 150769 [details, diff]
02_postal-0.69-nossl.patch

The configure.in was badly borked before. Excessive use of negative logic was the cause. Making a wrapper around that logic and fixing the build errors that were blocking a ssl-free build.

[Comment 3 Peter Alfredsen (RETIRED) 2008-04-24 00:03:34 UTC]

Created attachment 150770 [details, diff]
03_postal-0.69-c++0x-integrated.patch

When compiling the source resulting from the last two patches with gcc-4.3.0, gcc was spitting out errors about postal's use of hash_map. Fix up with stdc++0x code and put some autoconf magic in place to switch it on and off. Tested with both gcc-4.3.0 and gcc-4.2.3.

[Comment 4 Peter Alfredsen (RETIRED) 2008-04-24 00:04:38 UTC]

Created attachment 150771 [details, diff]
04_postal-0.69-warnings.patch

Fixup a warning. Now compiles with -Werror, if one is so inclined.

[Comment 5 Peter Alfredsen (RETIRED) 2008-04-24 00:05:22 UTC]

Created attachment 150772 [details, diff]
05_postal-0.69-fix-version.patch

Fixup for version being incorrect.

[Comment 6 Peter Alfredsen (RETIRED) 2008-04-24 00:08:47 UTC]

Created attachment 150773 [details, diff]
postal-0.62--0.69.ebuild.patch

Diff from 0.62 to 0.69. Licence ->gpl-3, logic for using gnutls and openssl consistent with autoconf magic, simplified ebuild due to QA improvements.

[Comment 7 Peter Alfredsen (RETIRED) 2008-04-24 00:11:15 UTC]

I believe these patches to be incremental from 01-->05, so any features can be punted by punting a patch. I'll be sending upstream a note about this bug.

[Comment 8 Tobias Scherbaum (RETIRED) 2008-06-15 12:19:25 UTC]

Fixed in CVS, bumped to postal-0.70. Thanks for your patches, Peter!