Bug 218590 – ivtv 1.0.3-r2 hard depped to kernel_is 2 6 22 etc and not 2 6 25

• Product: Gentoo Linux
• Status: RESOLVED INVALID

[Description Michael Evans 2008-04-20 15:07:48 UTC]

ivtv's latest build is hard depped to specific kernel versions.   This is not correct as while it may not work with higher kernel versions, the range should be determined on failure, not on lack of known good or bad.

Reproducible: Always

Steps to Reproduce:
1. Install a 2.6.25 kernel
2. emerge ivtv
3. failure

Actual Results:  
* Messages for package media-tv/ivtv-1.0.3-r2:

 * Each IVTV driver branch will only work with a specific
 * linux kernel branch.
 *
 * You will need to either:
 * a) emerge a different kernel
 * b) emerge a different ivtv driver
 *
 * See http://ivtvdriver.org/ for more information
 *
 * ERROR: media-tv/ivtv-1.0.3-r2 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called pkg_setup
 *    ivtv-1.0.3-r2.ebuild, line   46:  Called die
 * The specific snippet of code:
 *              die "This only works on 2.6.22 and greater kernels"
 *  The die message:
 *   This only works on 2.6.22 and greater kernels


Expected Results:  
Try working against 2.6.25 sources.

        if ! ( kernel_is 2 6 22 || kernel_is 2 6 23 || kernel_is 2 6 24 ); then
                eerror "Each IVTV driver branch will only work with a specific"
                eerror "linux kernel branch."
                eerror ""
                eerror "You will need to either:"
                eerror "a) emerge a different kernel"
                eerror "b) emerge a different ivtv driver"
                eerror ""
                eerror "See http://ivtvdriver.org/ for more information"
                die "This only works on 2.6.22 and greater kernels"
        fi

I suggest instead (based off of         kernel_is ge 2 6 25 && epatch "${FILESDIR}"/NVIDIA_kernel-96.43.05-2290218.diff from nvidia-drivers-96.43.05.ebuild)

        if ! ( kernel_is ge 2 6 22 ); then

until a range of working versions is determined, then:

        if ! ( kernel_is ge 2 6 22 && kernel_is le 2 6 XX ); then




The first of the suggested lines has been tested and works for me (it compiles successfully at any rate).

[Comment 1 Michael Evans 2008-04-21 11:40:34 UTC]

Created attachment 150490 [details]
ivtv ebuild with corrected version check.

ivtv ebuild with corrected version check as per my prior post.

[Comment 2 Doug Goldstein (RETIRED) 2008-07-08 16:00:45 UTC]

This is actually wrong since there's different versions for the higher kernels. These new versions appear in the tree.