Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 21775

Summary: sather 1.3 fails to compile
Product: Gentoo Linux Reporter: Matze Braun <matze>
Component: New packagesAssignee: George Shapovalov (RETIRED) <george>
Status: RESOLVED FIXED    
Severity: major    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: fixed ebuild
patch needed for the new ebuild

Description Matze Braun 2003-05-27 12:39:56 UTC
the sather1.3 ebuild fails to compile on my system. I had todo some small
changes which are attached to this bugreport.

System:
gentoo linux on x86 pentium4 cpu
gcc 3.2.2

Problems:
* variables of the form
        volatile unsigned int bla;
  need to be defined
        extern volatile unsigned int bla;
  in headers (the volatile was missing)

* the garbage collection library -lgc contains references to -ldl so we need
  to link this lib as well.
Comment 1 Matze Braun 2003-05-27 12:40:41 UTC
Created attachment 12460 [details]
fixed ebuild
Comment 2 Matze Braun 2003-05-27 12:41:34 UTC
Created attachment 12461 [details, diff]
patch needed for the new ebuild
Comment 3 George Shapovalov (RETIRED) gentoo-dev 2003-06-13 20:32:33 UTC
Hi Matze.

Thanks for the report and a fix!
I have tested it and committed the changes. Please test.
Looking at when the ebuild was committed I can only suspect that this breakage has something to do with gcc-3. Fortunately your fix does not have any bad side-effects on gcc-2.95.x based system.

I also cleaned up[ the ebuild - "sather" was used in a lot of places, I changed it to ${PN} and used ${MY_P} where appropriate + some more stuff.
I removed definition of LOCALE from generated env file - its not good to force some weird LOCALE on unsuspecting users :/.
Also, since this is a compile-time fix, no revision bump is necessary. 

TODO item:
Everything (well almost) gets installed under /usr/sather, which is not quite FHS compliant. Not sure if it would be easy to move stuff under uppropriate places but at least symlinks can be placed into /usr/bin and may be somewhere else.
Still getting in the fix is top priority, so I committed the changes you made right away. May I be will get to sorting installation out at some point, so leaving this bug open for a while. BTW, do you have any idea how anybody else (most likely that would be Debian) installs this package?

George
Comment 4 George Shapovalov (RETIRED) gentoo-dev 2004-02-02 20:57:41 UTC
reclosing the bug
Comment 5 George Shapovalov (RETIRED) gentoo-dev 2004-02-27 17:12:34 UTC
rereclosing the bug