Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 217326

Summary: Suggestion: Make horde modules depend on either horde, horde-groupware or horde-webmail
Product: Gentoo Linux Reporter: Robin Bankhead <gentoo>
Component: [OLD] ServerAssignee: SpanKY <vapier>
Status: RESOLVED FIXED    
Severity: enhancement CC: web-apps
Priority: High    
Version: 2007.0   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: patch for horde-chora-2.0.2.ebuild
patch to horde-gollem-1.0.3.ebuild
patch to horde-imp-4.1.6.ebuild
patch to horde-ingo-1.1.5.ebuild
patch to horde-jeta-1.0.ebuild
patch to horde-mimp-1.0.2.ebuild
patch to horde-passwd-3.0.1.ebuild

Description Robin Bankhead 2008-04-11 18:49:51 UTC
I would like to suggest that individual horde modules depend on one of horde, horde-webmail or horde-groupware.

Reason: currently, modules that are not included in horde-webmail or horde-groupware cannot be emerged if the respective package is installed, because they depend on horde, which is blocked by these "combined" packages.

Example: horde-webmail does not include horde-mimp, but it's quite feasible that one might want to emerge this too. Not possible, because of the block. 

To preserve the necessary aspect of preventing individual modules being emerged when one of the combi packages that includes them is already merged, make the combi package(s) block that module, or make them depend on horde only (as is currently true).

If this change is agreed in principle, I will be happy to compile a list of what would need changed for which packages.
Comment 1 SpanKY gentoo-dev 2008-04-12 21:27:36 UTC
idea sounds sane enough ... if you want to post patches, that'd be good
Comment 2 Robin Bankhead 2008-04-13 09:29:36 UTC
I'll give it a go, will need to learn how first though ;)

Here's that list:

1) blocks
- www-apps/horde blocks www-apps/horde-groupware, www-apps/horde-webmail
- www-apps/horde-groupware blocks www-apps/horde, www-apps/horde-webmail
- www-apps/horde-webmail blocks www-apps/horde, www-apps/horde-groupware

2) depends
- www-apps/horde-chora depends on www-apps/horde OR www-apps/horde-groupware OR www-apps/horde-webmail
- www-apps/horde-gollem depends on www-apps/horde OR www-apps/horde-groupware OR www-apps/horde-webmail
- www-apps/horde-imp depends on www-apps/horde OR www-apps/horde-groupware
- www-apps/horde-ingo depends on www-apps/horde OR www-apps/horde-groupware
- www-apps/horde-jeta depends on www-apps/horde OR www-apps/horde-groupware OR www-apps/horde-webmail
- www-apps/horde-kronolith depends on www-apps/horde
- www-apps/horde-mimp depends on www-apps/horde OR www-apps/horde-groupware OR www-apps/horde-webmail
- www-apps/horde-mnemo depends on www-apps/horde
- www-apps/horde-nag depends on www-apps/horde
- www-apps/horde-passwd depends on www-apps/horde OR www-apps/horde-groupware OR www-apps/horde-webmail
- www-apps/horde-turba depends on www-apps/horde

I'll see what I can do with these.
Comment 3 Robin Bankhead 2008-04-13 15:48:26 UTC
Created attachment 149564 [details, diff]
patch for horde-chora-2.0.2.ebuild

Hope I have got these in appropriate format... six more to come.
Comment 4 Robin Bankhead 2008-04-13 15:49:28 UTC
Created attachment 149566 [details, diff]
patch to horde-gollem-1.0.3.ebuild
Comment 5 Robin Bankhead 2008-04-13 15:50:05 UTC
Created attachment 149568 [details, diff]
patch to horde-imp-4.1.6.ebuild
Comment 6 Robin Bankhead 2008-04-13 15:50:38 UTC
Created attachment 149570 [details, diff]
patch to horde-ingo-1.1.5.ebuild
Comment 7 Robin Bankhead 2008-04-13 15:51:15 UTC
Created attachment 149571 [details, diff]
patch to horde-jeta-1.0.ebuild
Comment 8 Robin Bankhead 2008-04-13 15:52:05 UTC
Created attachment 149572 [details, diff]
patch to horde-mimp-1.0.2.ebuild
Comment 9 Robin Bankhead 2008-04-13 15:52:57 UTC
Created attachment 149574 [details, diff]
patch to horde-passwd-3.0.1.ebuild
Comment 10 SpanKY gentoo-dev 2008-04-14 00:37:02 UTC
in the future, make sure you create unified style diffs, not context style

the changes all look fine, just one quick question before i merge them ... think we should have horde blocking the groupware/webmail packages ?  or just leave them alone since they install into non-conflicting directories ?
Comment 11 Robin Bankhead 2008-04-14 00:59:28 UTC
I would think all three should block each other, to avoid redundancy. The only f'rinstance I can think of to support not doing so is having a range of different vhosts that you wanted to construct various combinations on. In such an instance, though, I would think you'd just be better off choosing all separate packages rather than the meta-packages.
Comment 12 Robin Bankhead 2008-05-19 19:43:22 UTC
Is there anything else I need to do re: this?