Bug 217151

Summary:	app-emulation/xen building with gcc-4.3.0 fails with sed error
Product:	Gentoo Linux	Reporter:	Bert Karwatzki <spasswolf>
Component:	[OLD] GCC Porting	Assignee:	Gentoo Xen Devs <xen>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ktulhu.fthagn, mail, marco, steeeeeveee
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://thread.gmane.org/gmane.comp.emulators.xen.devel/55465
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	198121
Attachments:	Patch fixing sed command in xen/Makefile Ebuild for patch above Ebuild for Xen 3.2.1 (see patch above) xen-sed-gcc.patch

Description Bert Karwatzki 2008-04-10 15:31:59 UTC

building app-emulation/xen (all versions) fails with gcc-4.3.0

make -f /var/tmp/portage/app-emulation/xen-3.2.0/work/xen-3.2.0/xen/Rules.mk include/xen/compile.h
make[2]: Entering directory `/var/tmp/portage/app-emulation/xen-3.2.0/work/xen-3.2.0/xen'
sed: -e expression #6, char 945: unterminated `s' command
make[2]: *** [include/xen/compile.h] Error 1

emerging xen works fine with gcc-4.2.3

Reproducible: Always

Steps to Reproduce:
1.
2.

Comment 1 Bert Karwatzki 2008-04-10 15:34:09 UTC

Created attachment 149315 [details]
Patch fixing sed command in xen/Makefile

This patch escapes two "-characters.

Comment 2 Bert Karwatzki 2008-04-10 15:35:04 UTC

Created attachment 149317 [details]
Ebuild for patch above

Comment 3 Bert Karwatzki 2008-04-10 17:16:19 UTC

I think this bug is caused by the output of "gcc -v":
For Version 4.2.3 it contains:
--with-pkgversion=Gentoo 4.2.3 p1.0
for Version 4.3.0 it contains:
--with-pkgversion='Gentoo 4.3.0 p1.0'
The single quotes of the second output mess up a sed command in line #173 of xen/Makefile.

Comment 4 steveb 2008-05-28 13:35:18 UTC

The patch works as well for XEN 3.2.1. I wonder why this is not in portage jet?

@Bert: Have you already reported the issue upstream?

Comment 5 Salvatore Cristofaro 2008-06-17 09:04:44 UTC

Created attachment 157221 [details]
Ebuild for Xen 3.2.1 (see patch above)

Allow xen 3.2.1 to be compiled with gcc 4.3.x

Comment 6 Salvatore Cristofaro 2008-06-17 09:15:19 UTC

Pls add the 198121 dependency tree. 
Tnx

Comment 7 Robert Buchholz (RETIRED) gentoo-dev

2008-08-26 22:55:28 UTC

*** Bug 221269 has been marked as a duplicate of this bug. ***

Comment 8 Robert Buchholz (RETIRED) gentoo-dev

2008-08-26 22:55:37 UTC

*** Bug 235531 has been marked as a duplicate of this bug. ***

Comment 9 Robert Buchholz (RETIRED) gentoo-dev

2008-08-26 22:58:21 UTC

Created attachment 163863 [details, diff]
xen-sed-gcc.patch

Quoting issues are only a symptom, not the cause of the problem. If you fix them, you still end up with a messed up "compiler" information in the Xen boot screen.

I will include the attached patch that uses --version instead of -v for GCC eyecandy.

Comment 10 Robert Buchholz (RETIRED) gentoo-dev

2008-09-01 00:31:50 UTC

+*xen-3.3.0 (01 Sep 2008)
+
+  01 Sep 2008; Robert Buchholz <rbu@gentoo.org> +files/xen-sed-gcc.patch,
+  metadata.xml, -xen-3.2.0.ebuild, xen-3.2.1.ebuild, +xen-3.3.0.ebuild:
+  Version bump to Xen 3.3 (bug #201792).
+  Bugs fixed:
+   * Fix invalid sed that broke gcc-4.3 (bug #217151)
+