Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 216008

Summary: [PATCH] media-video/mpeg4ip-1.5.0.1-r4 fails to compile with gcc-4.3
Product: Gentoo Linux Reporter: Martin Väth <martin>
Component: [OLD] GCC PortingAssignee: Olivier Crete (RETIRED) <tester>
Status: RESOLVED FIXED    
Severity: normal CC: esigra
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 198121    
Attachments: Fix includes, stream usage, and array bounds for gcc-4.3

Description Martin Väth 2008-04-03 09:17:42 UTC
media-video/mpeg4ip-1.5.0.1-r4 fails to compile with gcc-4.3
Comment 1 Martin Väth 2008-04-03 09:26:52 UTC
Created attachment 148190 [details, diff]
Fix includes, stream usage, and array bounds for gcc-4.3

Three types of errors were necessary to fix to compile with gcc-4.3:

1. For #include <iostream.h> (and similar things) the ".h" was removed.
2. "cout" and similar things were used without "std::"
3. gcc spits an "out of array bounds" warning which by -Werror was converted to
an error. Since I don't know how to avoid this warning, -Werror was removed
from a Makefile.ac

My fix for 2. was simply to add "using namespace std;" which is certainly not
the cleanest the solution, but works well and - hey, it's a patch!
Because of 3. it is necessary to apply the patch before "autoreconf".
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-05-07 21:12:48 UTC
Thanks for the patch, fixed.