| Summary: | net-irc/ircproxy-1.3.4c - please add to the tree | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Konstantin Shabanov <kes.eclipse> |
| Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
| Status: | RESOLVED OBSOLETE | ||
| Severity: | enhancement | CC: | frank, jstein, net-irc |
| Priority: | High | Keywords: | EBUILD |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://ircproxy.sf.net/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | ebuilds for net-irc/ircproxy-1.3.3c (stable) and 1.3.4c (latest) | ||
|
Description
Konstantin Shabanov
2008-04-02 19:04:15 UTC
Created attachment 178619 [details] ebuilds for net-irc/ircproxy-1.3.3c (stable) and 1.3.4c (latest) ebuilds for ircproxy from http://forum.night-light.net/. Included the latest and stable versions from upstream, and an init script. This is my first from-scratch ebuild, comments for improvement welcome. Frank, are you still interested in or willing to clean up the ebuilds you attached?
> This is my first from-scratch ebuild, comments for improvement welcome.
You should be able to get rid of src_unpack() and just use src_prepare() for sed-ing up the source. You should also probably update the eubild to use EAPI=4, which means fewer die() calls (and econf() should never have || die).
(In reply to comment #2) > Frank, are you still interested in or willing to clean up the ebuilds you > attached? > > > This is my first from-scratch ebuild, comments for improvement welcome. > > You should be able to get rid of src_unpack() and just use src_prepare() for > sed-ing up the source. You should also probably update the eubild to use > EAPI=4, which means fewer die() calls (and econf() should never have || die). I haven't been using Gentoo much lately, so I don't currently have an environment to test any changes on. If no one else gets to it, I might do it when I get some down time at work. That will probably be a while, but seeing as how this has been pending for a few years that's probably OK. all upstream URLs are dead. |
