Summary: | x11-plugins/wm* stable request | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Tiago Cunha (RETIRED) <tcunha> |
Component: | New packages | Assignee: | Sparc Porters <sparc> |
Status: | RESOLVED INVALID | ||
Severity: | enhancement | CC: | desktop-dock |
Priority: | High | Keywords: | STABLEREQ |
Version: | 2007.0 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
wmbutton-0.6.1.ebuild.patch
wmcalendar-0.5.0-r1.ebuild.patch wmclock-1.0.12.2.ebuild.patch wmdf-0.1.6-r1.ebuild.patch wmdl-1.4.1.ebuild.patch wmdrawer-0.10.5-r2.ebuild.patch wmfsm-0.34-r1.ebuild.patch wmsystray-0.1.1.ebuild.patch wmupmon-0.1.3-r1.ebuild.patch wmbio-1.02.ebuild.patch wmcp-1.2.8.ebuild.patch wmitime-0.3.ebuild.patch wmload-0.9.2.ebuild.patch wmcube-0.98.ebuild.patch |
Description
Tiago Cunha (RETIRED)
![]() Created attachment 147912 [details, diff]
wmbutton-0.6.1.ebuild.patch
* Quote ${DISTDIR}.
Created attachment 147914 [details, diff]
wmcalendar-0.5.0-r1.ebuild.patch
* Avoid pre-stripping.
* Fix hardcoded CC.
* make -> emake in src_install;
* Quote ${D}, ${FILESDIR}, ${S}, ${WORKDIR}.
* Respect FHS and install the manpages to /usr/share/man.
Created attachment 147915 [details, diff]
wmclock-1.0.12.2.ebuild.patch
* Avoid pre-stripping.
* Order variables.
* Remove redundant src_compile.
* Shorten description ("new" repoman check).
Created attachment 147916 [details, diff]
wmdf-0.1.6-r1.ebuild.patch
* Order variables.
* Quote ${FILESDIR}, ${S}.
* Remove redundant src_compile.
* Sort KEYWORDS.
Created attachment 147917 [details, diff]
wmdl-1.4.1.ebuild.patch
* Fix hardcoded CC.
* make -> emake in src_compile.
* Order variables.
* Quote ${FILESDIR}, ${S}.
Created attachment 147919 [details, diff]
wmdrawer-0.10.5-r2.ebuild.patch
* Avoid pre-stripping.
* Fix hardcoded CC.
* Order variables.
* Manpage path corrected in src_install.
Created attachment 147921 [details, diff]
wmfsm-0.34-r1.ebuild.patch
* Order variables.
* Quote ${FILESDIR}, ${S}.
* Remove redundant src_compile.
* Sort KEYWORDS.
Created attachment 147923 [details, diff]
wmsystray-0.1.1.ebuild.patch
* Fix hardcoded CC.
Created attachment 147925 [details, diff]
wmupmon-0.1.3-r1.ebuild.patch
* Quote ${S}.
* Remove redundant src_compile.
A lot of these changes are already in tree.. not a fun bug to browse :) For the moment, I stabilized the following ebuilds on SPARC: x11-plugins/wmMoonClock-1.27-r1 x11-plugins/wmbinclock-0.5 x11-plugins/wmbio-1.02 x11-plugins/wmblob-1.0.3 x11-plugins/wmbluecpu-0.6 x11-plugins/wmbutton-0.6.1 x11-plugins/wmcalc-0.4 x11-plugins/wmcp-1.2.8 x11-plugins/wmdate-0.7 x11-plugins/wmdf-0.1.6-r1 x11-plugins/wmfortune-0.241 x11-plugins/wmitime-0.3 x11-plugins/wmload-0.9.2 x11-plugins/wmmemfree-0.7-r2 x11-plugins/wmtop-0.9.0 x11-plugins/wmtz-0.7 x11-plugins/wmupmon-0.1.3-r1 However, consider the following warnings for: - x11-plugins/wmbio-1.02: CC hardcoded, and dodoc: ../ChangeLog does not exist. - x11-plugins/wmcp-1.2.8: uses -g during the compile phase. - x11-plugins/wmitime-0.3: CC hardcoded. - x11-plugins/wmload-0.9.2: CC hardcoded, and implicit declarations QA warning. - x11-plugins/wmupmon-0.1.3-r1: implicit declarations QA warning. Created attachment 173669 [details, diff]
wmbio-1.02.ebuild.patch
* Fix hardcoded CC.
* ChangeLog -> Changelog.
Created attachment 173671 [details, diff]
wmcp-1.2.8.ebuild.patch
* Don't produce debug information by default.
Created attachment 173672 [details, diff]
wmitime-0.3.ebuild.patch
* Fix hardcoded CC.
* Make the package use the proper CFLAGS from the portage environment in src_compile instead of patching the Makefile.
* Redefine S to avoid doing cd "${S}" in src_compile, and src_install.
* Use emake instead of make in src_compile.
Created attachment 173673 [details, diff]
wmload-0.9.2.ebuild.patch
* Fix hardcoded CC.
Created attachment 173681 [details, diff]
wmcube-0.98.ebuild.patch
* Fix hardcoded CC.
* Honour Gentoo CFLAGS. This is critical on SPARC, since GCC generates v7 code by default, which forces kernel emulation (v7 has no hardware integer multiply or divide).
I stabilized the following ebuilds on SPARC: x11-plugins/wmdl-1.4.1 x11-plugins/wminet-3.0.0 x11-plugins/wmmemload-0.1.6 x11-plugins/wmnetmon-0.2_p5 x11-plugins/wmpiki-0.2.1 However, consider the following warnings for: x11-plugins/wmdl-1.4.1: CC hardcoded x11-plugins/wmpiki-0.2.1: CC hardcoded Also, the following ebuilds have bugs opened: x11-plugins/wmSun: #248616 x11-plugins/wmcalendar: #248626 x11-plugins/wmdrawer: #248640 x11-plugins/wmget: #248641 x11-plugins/wmmsg: #248645 (In reply to comment #17) > Also, the following ebuilds have bugs opened: > x11-plugins/wmSun: #248616 > x11-plugins/wmcalendar: #248626 > x11-plugins/wmdrawer: #248640 > x11-plugins/wmget: #248641 > x11-plugins/wmmsg: #248645 All these bugs are now fixed. (In reply to comment #17) > However, consider the following warnings for: > x11-plugins/wmdl-1.4.1: CC hardcoded > x11-plugins/wmpiki-0.2.1: CC hardcoded These are now fixed, too. I stabilized the following ebuilds on SPARC: x11-plugins/wmDownload-0.1.2a-r1 x11-plugins/wmSun-1.03-r1 x11-plugins/wmcalendar-0.5.2 x11-plugins/wmdiskmon-0.0.1 x11-plugins/wmfire-1.2.3 x11-plugins/wmfsm-0.34-r1 x11-plugins/wmjsql-0.5 x11-plugins/wmix-3.1-r1 x11-plugins/wmmaiload-2.2.1-r1 x11-plugins/wmmp3-0.12 x11-plugins/wmsmixer-0.5.1 Minor issues: x11-plugins/wmjsql-0.5: Does not respect CC, nor LDFLAGS. x11-plugins/wmmp3-0.12: Does not respect CC. Repoman warnings: x11-plugins/wmDownload/wmDownload-0.1.2a-r1.ebuild: RDEPEND is not explicitly assigned x11-plugins/wmjsql/wmjsql-0.5.ebuild: Unquoted Variable on line: 27 x11-plugins/wmjsql/wmjsql-0.5.ebuild: Unquoted Variable on line: 33 x11-plugins/wmjsql/wmjsql-0.5.ebuild: Unquoted Variable on line: 37 x11-plugins/wmjsql/wmjsql-0.5.ebuild: Unquoted Variable on line: 41 x11-plugins/wmmp3/wmmp3-0.12.ebuild: Unquoted Variable on line: 27 x11-plugins/wmmp3/wmmp3-0.12.ebuild: Unquoted Variable on line: 30 There are still a few missing, though. I'll finish the list as time permits. Sorry for my (lack of) activity lately. Any news on this one? Btw, having a single bug for 10ish different packages makes it rather difficult to track what has been fixed and what is still needed... Not really, unfortunately. Like most other architectures we have quite a few other bugs to work on, which will hopefully change in the future. However, looking at the output of the imlate script, these are the missing ones: x11-plugins/wmclock x11-plugins/wmcube x11-plugins/wmdrawer x11-plugins/wmget x11-plugins/wmifinfo x11-plugins/wmmsg x11-plugins/wmpager x11-plugins/wmpasman x11-plugins/wmpeople x11-plugins/wmpop3 x11-plugins/wmpop3lb x11-plugins/wmsystray x11-plugins/wmtimer x11-plugins/wmweather+ x11-plugins/wmxkb This has been open too long, and got difficult to handle (too many packages to consider in one single bug). Closing. Please file different bugs for different packages. |