Bug 21551 – ppp-2.4.1-r14 fails with unescaped multi-line string

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jim Bray 2003-05-23 10:17:19 UTC]

I"m using gcc-3.3.

pppoe.c:200:28: missing terminating " character
pppoe.c:201:52: missing terminating " character
make[2]: *** [pppoe.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory
`/var/tmp/portage/ppp-2.4.1-r14/work/ppp-2.4.1.pppoe4/pppd/plugins/pppoe'
make[1]: *** [pppoe/pppoe.so] Error 2
make[1]: Leaving directory
`/var/tmp/portage/ppp-2.4.1-r14/work/ppp-2.4.1.pppoe4/pppd/plugins'
make: *** [all] Error 2

 The failing code:

	    poe_error (ses," Service name too long
	                (maximum allowed 256 chars)");



Reproducible: Always
Steps to Reproduce:
1.
2.
3.




gcc/1#emerge info
Portage 2.0.48 (default-x86-1.4, gcc-3.3, glibc-2.3.2-r1)
=================================================================
System uname: 2.4.20-gentoo-r5 i586 AMD-K6(tm) 3D processor
GENTOO_MIRRORS="http://gentoo.oregonstate.edu http://distro.ibiblio.org/pub/Linu
                                   
x/distributions/gentoo"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config /usr/kde/3/share
                                   
/config /usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config /usr/share/texmf/tex/ge
                                   
neric/config/ /usr/share/texmf/tex/platex/config/ /usr/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
PORTDIR="/usr/portage"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR_OVERLAY=""
USE="x86 oss avi crypt encode gif jpeg libg++ mikmod mpeg ncurses pdflib png qui
                                   
cktime spell truetype xml2 xv zlib gtkhtml gdbm berkdb slang readline tetex tclt
                                   
k java guile X gpm tcpd pam libwww ssl perl python esd imlib oggvorbis gtk motif
                                   
 mozilla scanner acpi acpi4linux xfs gtk2 gnome mbox alsa xmms mmx 3dnow opengl
                                    
matrox dga cdr bonobo pic leim -kde -qt -arts -svga -sdl -cups -apm -postgres -d
                                   
vd -nls"
COMPILER="gcc3"
CHOST="i586-pc-linux-gnu"
CFLAGS="-march=k6-2 -O3 -Os -freorder-blocks -pipe"
CXXFLAGS="-march=k6-2 -O3 -Os -freorder-blocks -pipe"
ACCEPT_KEYWORDS="x86 ~x86"
MAKEOPTS="-j2"
AUTOCLEAN="yes"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
FEATURES="sandbox ccache"

[Comment 1 Chuck Brewer 2003-05-23 12:31:02 UTC]

I hate to say this, but gcc 3.3 is still most of a hack, which is why it's still in
packages.mask. Have you gotten any version to build with 3.3? The source hasn't changed since before -r6 and everything I've done to it lately has been cosmetic, really, besides adding in the pppoatm plugin (which is why I committed r14).My only 
suggestion atm is to roll back to gcc-3.2.3-20030422 which is the latest Ive gotten it to build with.

[Comment 2 Jim Bray 2003-05-23 17:34:34 UTC]

 Well, the code will need to be changed sooner or later. Might want to
tell upstream.

http://gcc.gnu.org/gcc-3.3/changes.html

GCC 3.3 Release Series
Changes, New Features, and Fixes
Caveats

    * The preprocessor no longer accepts multi-line string literals. They were deprecated in 3.0, 3.1, and 3.2.

http://bugs.gentoo.org/show_bug.cgi?id=21551

[Comment 3 Chuck Brewer 2003-05-26 04:36:34 UTC]

Jim, if you get a chance, can you try out the redone r14? lu_zero added a gcc 3.3 patch for that, and I could use the input:)

[Comment 4 Jim Bray 2003-05-26 15:08:15 UTC]

Built and installed without incident.

  I suspect you'll see a lot of these string bugs with gcc-3.3. Lots
of code-cleanups will be triggered by this.

gcc-3.3 seems to be solid as far as c is concerned. I'm not sure about
the g++ yet. Building the Lizard should be revealing.

[Comment 5 Chuck Brewer 2003-05-27 01:20:33 UTC]

Okay, I'm gonna close this one then. As soon I get a chance I really need to revamp this whole pckage, and push upstream for a new release, sicne theres atleast 15 patches against it so far I'd like to see in a new release. I'll give r14 the customary 2 weeks and push it stable, thanks:)