Bug 215480

Summary:	gtkcdlabel segfault on cddb query
Product:	Gentoo Linux	Reporter:	Jörg Ahrens <joerg>
Component:	Current packages	Assignee:	Gentoo Optical Media project <media-optical>
Status:	RESOLVED TEST-REQUEST
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Jörg Ahrens 2008-03-30 19:33:21 UTC

gtkcdlabel does not anticipate multiple DTITLE Lines as a result of a cddb query. As the second line returned does not contain a slash a strok() returns NULL ... (see cddb.c)

Actually there is a second bug: gtkcdlabel does not anticipate multiple TITLEn Lines for the same Title. As a result, only the content of the last line is used, no segfault here.


Reproducible: Always

Steps to Reproduce:
1. Insert a CD with a long Title (for instance Pink Floyd / The Piper at The Gates of Dawn ...)
2. start gtkcdlabel and press <GET CDDB> Button.
3. to reproduce the second bug, you could use Pink Floyd : Umma Gumma (Disc 2) which has a Track with a rather long name (Several Species of Small Furry Animals gathered together in a Cave and Grooving with a Pict :-)

Actual Results:  
Bug 1: segfault
Bug 2: only the last part of the title is used

Expected Results:  
Bug 1: no segfault
Bug 2: the complete Title should be used

The Code in cddb.c has no sanity checks. Maybe libcddb could be used instead of this Code.

Comment 1 Samuli Suominen (RETIRED) gentoo-dev

2008-06-04 19:04:01 UTC

Please try with 1.12, upstream rewrote the app using pygtk....

*gtkcdlabel-1.12 (14 May 2008)

  14 May 2008; Samuli Suominen <drac@gentoo.org> +gtkcdlabel-1.12.ebuild:
  Version bump wrt #221993, thanks to Fabio Rossi.

Comment 2 Jörg Ahrens 2008-06-07 18:26:17 UTC

(In reply to comment #1)

Both Bugs are fixed in 1.12