Bug 214700

Summary:	kernel/input/evdev: force feedback not working in 32bit apps on 64bit kernel
Product:	Gentoo Linux	Reporter:	Adam Dawidowski <drake>
Component:	[OLD] Core system	Assignee:	Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	drake
Priority:	High	Keywords:	InVCS
Version:	unspecified
Hardware:	AMD64
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Proposed patch

Description Adam Dawidowski 2008-03-25 14:32:19 UTC

Force feedback upload of effects through the event device (ioctl EVIOCSFF) is not working in 32 bit apps like wine.
64 bit apps like fftest work.

This is due to the fact that struct ff_effect contains a pointer, resulting in the structure having different sizes in 64 and 32 bit programs. This means that the ioctl issued from 32 bit code isn't handled, because it has a different number.

Comment 1 Adam Dawidowski 2008-03-25 14:35:18 UTC

Created attachment 147267 [details, diff]
Proposed patch

This patch makes force feedback work in 32 bit apps for me.

Comment 2 Mike Pagano gentoo-dev

2008-03-25 15:55:28 UTC

Are you the author? Has this been submitted upstream?

Comment 3 Adam Dawidowski 2008-03-25 19:11:24 UTC

Yes. No.

Comment 4 Mike Pagano gentoo-dev

2008-03-25 19:26:59 UTC

We typically only backport patches from the official upstream development kernel tree.

http://dev.gentoo.org/~dsd/genpatches/faq.htm

Are your plans to submit this upstream?

Comment 5 Adam Dawidowski 2008-03-25 21:12:49 UTC

It seems I don't have a choice ;]
I'll get on it right away.

Comment 6 Mike Pagano gentoo-dev

2008-04-11 15:30:44 UTC

Adam, did you have a chance/are you still planning on submitting this upstream?

Comment 7 Adam Dawidowski 2008-04-13 13:18:09 UTC

I'm having trouble getting through to the devs.
I posted the patch to the linux-input list (this archive tells me that the mail got through: http://article.gmane.org/gmane.linux.kernel.input/4493), but got no reply. I then mailed Dmitry Torokhov, the maintainer of the input subsystem, but also got no reply. I must be doing something wrong...

Comment 8 Adam Dawidowski 2008-04-14 06:17:23 UTC

Nevermind, I got a response from Dmitry.

Comment 9 Mike Pagano gentoo-dev

2008-04-30 01:01:35 UTC

Adam,

Any movement on your patch from Dmitry?

Comment 10 Adam Dawidowski 2008-05-03 08:59:26 UTC

Nope. Nothing on the list either. I'll poke Dmitry again.

Comment 11 Adam Dawidowski 2008-05-12 17:41:42 UTC

Dmitry came up with a better patch and it should get commited Real Soon Now(TM).

Comment 12 Daniel Drake (RETIRED) gentoo-dev

2008-06-29 16:50:07 UTC

The patch got accepted into upstream input tree
http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commitdiff_plain;h=bb00421d9b684253468bf751e7ce0a4667b721e8
We'll include it in the next 2.6.25 release.

Comment 13 Daniel Drake (RETIRED) gentoo-dev

2008-07-01 02:34:05 UTC

fixed in gentoo-sources-2.6.25-r6