Bug 214515

Summary:	app-admin/perl-cleaner-1.05 uses glob pattern instead of regular expression
Product:	Gentoo Linux	Reporter:	Bernhard Frauendienst <gentoo>
Component:	Current packages	Assignee:	Paul Varner (RETIRED) <fuzzyray>
Status:	RESOLVED FIXED
Severity:	normal	CC:	johnparmitage, perl, Sergiy.Borodych
Priority:	High
Version:	2007.0
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	286910
Attachments:	Fixes a pattern in perl-cleaner

Description Bernhard Frauendienst 2008-03-24 13:08:16 UTC

perl-cleaner-1.05 has a function module_list() which uses grep to search a number of CONTENTS files. The pattern provided to grep is '/usr/lib*/perl5/', which would work for glob, but does not make much sense as a regular expression.

Correct me if I'm wrong, but I think it should be replaced with something like '/usr/lib[^/]*/perl5/' (which is what the attached patch does).

Comment 1 Bernhard Frauendienst 2008-03-24 13:12:27 UTC

Created attachment 147107 [details, diff]
Fixes a pattern in perl-cleaner

Comment 2 Sergiy Borodych 2009-08-19 20:18:34 UTC

anyone fix it please

IMHO '/usr/lib\w*/perl5/' is better

Comment 3 John Armitage 2009-08-29 13:29:24 UTC

perl-cleaner reallyall rebuilds nothing unless I apply this patch

Comment 4 Torsten Veller (RETIRED) gentoo-dev

2009-09-29 11:01:38 UTC

Should be fixed in =app-admin/perl-cleaner-2*