Summary: | net-p2p/btg-0.9.7 version bump request | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Tiziano Müller (RETIRED) <dev-zero> |
Component: | New packages | Assignee: | Christoph Mende (RETIRED) <angelos> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | beolach+gb, tuxie, volkmar |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
net-p2p/btg/files/btg-0.9.7-broken_bundled_plotmm_sigc.patch
net-p2p/btg/files/btg-0.9.7-as_needed.patch Patch for btg-0.9.6-r1.ebuild -> btg-0.9.7.ebuild Patch adding curl USE flag and minors enhancements Patch adding curl USE flag and minors enhancements Patch adding curl dep/USE flag and move dialog dep for !minimal USE flag |
Description
Tiziano Müller (RETIRED)
2008-03-24 09:51:48 UTC
An ebuild for the optional CyberLink library/dependency is in the Sunrise Overlay. ok, you've got a lot to fix for this app: a) Broken with as-needed (gonna attach a patch for it) b) Needs the CyberLink Library (http://sourceforge.net/projects/clinkcc/) for uPnP-support c) Comes bundled with PlotMM (plotmm.sf.net) which: a) needs a lot more than just the deps recorded in the ebuild d) this plotmm-library uses a deprecated API of libsigc++ which makes it break here d) Comes bundled with xmlrpc-epi (http://xmlrpc-epi.sourceforge.net/) which in turns includes Yet Another Version Of Expat (tm) ;-) Created attachment 147262 [details, diff]
net-p2p/btg/files/btg-0.9.7-broken_bundled_plotmm_sigc.patch
Fixing the broken plotmm
Created attachment 147264 [details, diff]
net-p2p/btg/files/btg-0.9.7-as_needed.patch
I'm sorry, but I've given up. This is the patch as far as I went. It still doesn't build, but it's a lot better already... maybe you can use it.
Created attachment 147266 [details, diff]
Patch for btg-0.9.6-r1.ebuild -> btg-0.9.7.ebuild
Any news? (In reply to comment #6) > Any news? > I've talk with btg devs to make Tiziano's bugs corrected. Here is the situation : a) As been corrected in the btg trunk. Should be in 0.9.8 version, I hope. b) Since rb_libtorrent will implement upnp with 0.14 release, btg should not depend on cyberlink anymore. c) and d) I have to look at these bugs and open a bug report on btg's tracker. I opened a bug about a plotmm ebuild. It will help to fix the issue with bundled plotmm in btg ebuild. In addition, btg has to check if plotmm is already install. I am going to propose a patch to btg team. Bug for plotmm is bug #225287 (http://bugs.gentoo.org/show_bug.cgi?id=225287) I opened a bug about a xmlrpc-epi ebuild. It will help to fix the issue with bundled xmlrpc-epi in btg ebuild. In addition, btg has to check if xmlrpc-epi is already install and has to delete bundled expat. I am going to fill a bug to btg team. Bug for xmlrpc-epi is bug #225295 (http://bugs.gentoo.org/show_bug.cgi?id=225295) (In reply to comment #2) > d) this plotmm-library uses a deprecated API of libsigc++ which makes it break > here > d) Comes bundled with xmlrpc-epi (http://xmlrpc-epi.sourceforge.net/) which in > turns includes Yet Another Version Of Expat (tm) ;-) plotmm is working fine with latest libsigc++ from portage. xmlrpc-epi doesn't include any version of expat : btg team adds it. Actually, I think it is regular libexpat. (In reply to comment #4) > I'm sorry, but I've given up. This is the patch as far as I went. It still > doesn't build, but it's a lot better already... maybe you can use it. > It actually did build for me w/ Tiziano's patches. Just a couple things I noticed: w/ USE flag "test" it should depend on cppunit, but doesn't, and the configure script isn't enabling the btg-config script, which is needed to create daemon.ini and client.ini files mentioned at the end of the emerge. Created attachment 157947 [details, diff]
Patch adding curl USE flag and minors enhancements
Since 0.9.7 ebuild is in portage, I've written a patch to add curl USE flag.
Actually, cppunit dependency for test useflag has been added in portage's 0.9.7 ebuild and it also contains all Tiziano's improvements.
Created attachment 157949 [details, diff]
Patch adding curl USE flag and minors enhancements
Oups, there was a small error in the previous patch...
Created attachment 157997 [details, diff]
Patch adding curl dep/USE flag and move dialog dep for !minimal USE flag
I've seen dialog is not a dependency of btg package but of btg-config script. So I've added dialog to !minimal USE flag and btg-config is added in the same case.
I've tested it and it's working great.
About plotmm and xmlrpc-epi, automatic detection and using external builds has been added to svn version of btg. I hope it will be released with 0.9.8 version. Bundled packages will not be removed because xmlrpc-epi and plotmm are not commonly distro's official packages. If they are added into portage, bundled version will not be used anymore. closing this for now as 0.9.7 is in portage. mounir, I'll keep your suggestions on my TODO, thanks for that |