Summary: | emerge sets xterm title to 'xterm' even with FEATURES="notitles" | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christian Birchinger (RETIRED) <joker> |
Component: | [OLD] Core system | Assignee: | Nicholas Jones (RETIRED) <carpaski> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | chris.rs, ehmsen, ftobin+gentoo-bugzilla |
Priority: | High | ||
Version: | 1.4_rc1 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | emerge-notitles.patch |
Description
Christian Birchinger (RETIRED)
2003-05-21 11:55:16 UTC
I've seen that VIM is able to restore the original window title after exiting. I din't see how that's possible but this way would be the perfect solution. (Even i would use the windowtitle feature if it would restore the old title after exiting) No it will not be the perfect solution, since touching the xterm title makes a lot of errormessages when emerge sig run from cron. One could argue that using emerge from cron, is a no-no, but when you are maintaining a lot of gentoo's with different setups, it is very practical to use cron and mail the results back... When you set the notitles feature it should not touch the title in any case. So if you use cronstuff ... you should use the notitles feature. And when you want emerge to change your title it touches it anyway. It does not change the situation when you set it to the previous value instead of xterm. It sends xterm title change ansi codes anyway. I agree with both. 1. When FEATURES="notitles" is set, emerge should not touch the title (but it does, as noted). 2. When FEATURES="notitles" is _not_ set, emerge should touch the title and if possible change the value back to the original title when it finishes. But then: Why is this bug still here? It could easily be fix as you note above. After the bug has been fixed, another bugreport should be filed with the request that emerge restores the original title (this new feature has nothing to do with this bugreport). Fixed for 48-r1 fixed 2.0.48-r1 does not fix it. The function xtermTitleReset() is executed without the if "notitles" not in portage.features: check. and the result is that the title is "xterm" after the emerge process even with FEATURES="notitles". Created attachment 14087 [details, diff]
emerge-notitles.patch
Nick, The above patch will fix the problem. Basically you fixed it for emergelog(), but for emergeexit() you forgot the wrap the xtermTitleReset() call. Matt i should mention that patch was against portage-2.0.48-r1 *** Bug 21512 has been marked as a duplicate of this bug. *** Added for >=2.0.49_pre8 |