Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 214005

Summary: dev-util/git-1.5.4.4 does not depend on dev-perl/Error but needs it for git add -i (dev-util/git-1.5.4.3 does NOT need dev-perl/Error)
Product: Gentoo Linux Reporter: Martin Hauser <bugs>
Component: New packagesAssignee: Robin Johnson <robbat2>
Status: RESOLVED FIXED    
Severity: minor CC: alt, ferdy, lhunath, sylvain.bertrand
Priority: High    
Version: unspecified   
Hardware: x86   
OS: OS X   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: git-1.5.4.4.ebuild patch

Description Martin Hauser 2008-03-20 10:25:39 UTC
dev-util/git-1.5.4.3 does not need dev-perl/Error for git add -i, git-1.5.4.4 does. Emerging dev-perl/Error fixes the problem and git resumes normal operation. Starting git-1.5.4.4 via git-add -i results in an error that Error.pm is not included in @INC.

Reproducible: Always

Steps to Reproduce:
1. do a git add -i
Comment 1 Fabian Groffen gentoo-dev 2008-03-20 10:30:28 UTC
@ferdy, robbat2:
currently RDEPEND for git-1.5.4.4 has
  perl?   ( dev-perl/Error dev-perl/Net-SMTP-SSL )

Is this a known new requirement, or are we building in the wrong way when USE=-perl?
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2008-03-20 10:32:40 UTC
Nothing alt-specific here, re-assigning.
Comment 3 Martin Hauser 2008-03-20 11:26:09 UTC
I should add to this that the error occured as i had USE=-perl for git (on OSX NET-SMTP-SSL isn't yet unmasked).
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-03-20 18:57:46 UTC
Thanks, I see in the 1.5.4.x series, dev-perl/Error is no longer optional.
Comment 5 Fabian Groffen gentoo-dev 2008-03-20 19:02:47 UTC
@Martin: thanks, Robin's fix will show up after tomorrow's sync in the Prefix tree.
Comment 6 Martin Hauser 2008-03-20 19:23:44 UTC
No problem and thanks for fixing.
Comment 7 Sylvain BERTRAND 2008-03-21 09:26:57 UTC
Please reopen the bug.
Indeed your ebuild for 1.5.4.4 is now pulling many perl dependencies for those who has USE="-perl" and do not want the perl git helper scripts.
See attache ebuild patch.
Comment 8 Sylvain BERTRAND 2008-03-21 09:27:42 UTC
Created attachment 146742 [details, diff]
git-1.5.4.4.ebuild patch
Comment 9 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-03-21 19:34:41 UTC
sylvain: Git has the following parts as Perl presently:
git-add -i
git-relink
git-remote
git-send-email
git-svn (optional)
git-archimport (optional)
git-cvsexport-commit (optional)
git-cvsimport (optional)
git-cvsserver (optional)

Eg, Perl is no longer optional, and this includes the dev-perl/Error module. If you want to get rid of the Perl stuff for the first 3-4 scripts above, go and submit C versions to upstream.
(P.S. Please CC yourself on a bug if you leave a comment on it and expect a response).
Comment 10 Sylvain BERTRAND 2008-03-21 20:51:20 UTC
>Eg, Perl is no longer optional
Yes it is. Those commands are not requiered to work with git (I am a git user). They are additional sweet on the side.

>go and submit C versions to upstream
If perl dependency is brut forced, certainly not. It would be sort of black mail. If perl dependency stays optional and if I realise I really need this sweet, I may, if I have time (I'm already trying to work on the GPL nvidia driver on my free time).

Gentoo with its use flags has the power to let the user choose (like gnome and mono). Don't blow that away, please.
Comment 11 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-03-21 21:11:59 UTC
sylvain: please see bug 214168, which is more suitable for this discussion now.
Comment 12 Martin Hauser 2008-03-25 11:43:53 UTC
The resolution choosen is not possible on Os X as least... as (I stated this before) USE=perl spawns a require to NET-SMTP-SSL ... and therefore prevents git-add -i and the like from being built. I do not see a senseable solution to this with giving both sides what they want (the git-non-perl fraction a non-perl dependant git and the perl-wanting fraction a git that builds... ) other then waiting for NET-SMTP-SSL ... 

Comment 13 Martin Hauser 2008-03-25 11:45:31 UTC
correction on my previous post, NET-SMTP-SSL is not even in prefix yet... 
Comment 14 Fabian Groffen gentoo-dev 2008-03-25 12:01:37 UTC
(In reply to comment #13)
> correction on my previous post, NET-SMTP-SSL is not even in prefix yet... 

please file a bug for that, before this vanishes in piles of other things to do..
Comment 15 Martin Hauser 2008-03-25 12:25:48 UTC
Filed Bug #214681 as enhancement request for that problem.
Comment 16 Fabian Groffen gentoo-dev 2008-04-07 14:29:57 UTC
*** Bug 216147 has been marked as a duplicate of this bug. ***