Summary: | repoman should complain about eapi when trying to use slot deps in eapi=0 | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Bo Ørsted Andresen (RETIRED) <zlin> |
Component: | Repoman | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | InVCS |
Priority: | High | ||
Version: | 2.1 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 216231 | ||
Attachments: |
a small patch to throw a fatal repoman error if EAPI mismatches are found in *RDEPEND
Same thing with correct spelling ;P |
Description
Bo Ørsted Andresen (RETIRED)
2008-03-16 22:26:55 UTC
We should be able to call portage.dep.dep_getslot and if it is not None require eapi 1 (or greater). I am unsure how to do this inside of the actual dep parser though; we'd have to validate each atom in DEPEND. Looking through repoman I see: if not portage.isvalidatom(token, allow_blockers=True) or \ ":" in token and myaux["EAPI"] == "0": So it looks like we already detect this but don't print anything. So maybe we should just add a second major error (EAPI1 features in EAPI0 detected)? Created attachment 146370 [details, diff]
a small patch to throw a fatal repoman error if EAPI mismatches are found in *RDEPEND
Can you test this?
Created attachment 146372 [details, diff]
Same thing with correct spelling ;P
(In reply to comment #2) > Can you test this? Given how I only run portage-2.1.4.4 applying the latest patch just results in a traceback. ;) AttributeError: 'module' object has no attribute 'dep' This is fixed in 2.1.5_rc1. |