Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 213134

Summary: games-board/qgo-1.5.4 fails building with sys-devel/gcc-4.3
Product: Gentoo Linux Reporter: Dennis Schridde <dschridde+gentoobugs>
Component: [OLD] GCC PortingAssignee: Gentoo Games <games>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 198121    
Attachments: build.log
possible patch
possible patch

Description Dennis Schridde 2008-03-12 13:29:49 UTC
qgo includes iostream.h in matrix.cpp which apparently was removed. log attached.

Reproducible: Always

Steps to Reproduce:
Comment 1 Dennis Schridde 2008-03-12 13:30:08 UTC
Created attachment 145895 [details]
build.log
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2008-03-12 23:38:34 UTC
see bug #198121:

"Until 4.3.0 is released, filing bugs without patches enclosed is strongly
discouraged and will very likely just end up being RESOLVED WONTFIX."
Comment 3 Dennis Schridde 2008-03-13 00:09:19 UTC
Hmm... To which bug shall I then attach any patches to if they get closed before I come to attaching a patch?
I'm currently rebuilding my whole system to figure out (kinda contribution like) which packages will break, so that you can at least have an idea of how much damage an update will cause. (I assume you don't build 100k+something packages at home just for testing, do you?) Do you believe me that it might take me a few days (I've got other stuff to do, too) to patch every package that is broken?
And how do you know which packages break by the bump, if you close them all?
This surely looks better on the stats, but it doesn't make much sense to me...
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2008-03-13 01:54:37 UTC
The implication is that you'll wait to file the bug until you actually *have* a patch instead of just talking about one.
Comment 5 Dennis Schridde 2008-03-13 07:26:24 UTC
I wish you a lot of fun bumping packages and noticing afterwards what they broke. :)
Comment 6 Dennis Schridde 2008-03-13 07:27:00 UTC
PS: Closing eyes doesn't make bugs go away.
Comment 7 Tristan Heaven (RETIRED) gentoo-dev 2008-03-13 09:23:49 UTC
I guess it just needs to include iostream instead of iostream.h?
Comment 8 Dennis Schridde 2008-03-13 10:50:09 UTC
Created attachment 145985 [details, diff]
possible patch

This patch seems to do the trick in a non-portage compile.
The iostream in tree.cpp was not needed. (Patch removes it.)
The one in matrix.cpp was only needed if NO_DEBUG was not defined. (Patch fixes it anyway, since the KDE code in ./admin/acinclude.m4.in seems to be ignored or overridden (possibly broken configure.in?).)
Comment 9 Dennis Schridde 2008-03-13 10:51:38 UTC
Created attachment 145986 [details, diff]
possible patch

This patch seems to do the trick in a non-portage compile.
The iostream in tree.cpp was not needed. (Patch removes it.)
The one in matrix.cpp was only needed if NO_DEBUG was not defined. (Patch fixes it anyway, since the KDE code in ./admin/acinclude.m4.in seems to be ignored or overridden (possibly broken configure.in?).)

I currently can not test this with portage, since --empty --world is still running and failing regularly. Thus my --resume would be broken by a parallel merge. (Does someone know how to keep the "todo" for more than one merge?)
Comment 10 Dennis Schridde 2008-03-14 00:10:32 UTC
reopening, now that there is a working patch.
Comment 11 Mr. Bones. (RETIRED) gentoo-dev 2008-03-14 06:20:40 UTC
Was this patch sent upstream?
Comment 12 Dennis Schridde 2008-03-14 11:42:51 UTC
Upstream is working on qgo-2. I didn't sent the patch to them.
Comment 13 Dennis Schridde 2008-03-19 11:41:13 UTC
Tracked upstream as http://sourceforge.net/tracker/index.php?func=detail&aid=1919484&group_id=41645&atid=430966

Any chance of inclusion into Portage?
Comment 14 Tristan Heaven (RETIRED) gentoo-dev 2008-03-19 11:58:58 UTC
Fixed, thanks.