Summary: | Ebuild : www-plugins/nspluginwrapper-0.9.91.5-r1. Errors in shared libraries cause npviewer and npconfig to segfault. | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jamal Natour <uk_coder> |
Component: | New packages | Assignee: | Patrick McLean <chutzpah> |
Status: | RESOLVED UPSTREAM | ||
Severity: | enhancement | CC: | jasmin-genbug, rb6, voyageur |
Priority: | High | ||
Version: | 2007.0 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
tarball with ebuild and patch
tarball with ebuild and patch patch to npw-config.c, to prevent segfaults crashing app patch to npw-viewer.c, to prevent segfaults crashing app patch to nspluginwrapper-0.9.91.5-r1.ebuild to update to nspluginwrapper-0.9.91.5-r3.ebuild |
Description
Jamal Natour
2008-03-09 18:08:09 UTC
Created attachment 145665 [details]
tarball with ebuild and patch
Tarball with updated ebuild including a patch to fix segfaulting.
Created attachment 145672 [details]
tarball with ebuild and patch
Same issues exists with npw-viewer as previous attachment corrected, this fixes segfaults in npviewer as well as npconfig
We don't want any tarballs; reopen with a plaintext unified diff and exact ebuild name and version the patch is about. (In reply to comment #3) > We don't want any tarballs; reopen with a plaintext unified diff and exact > ebuild name and version the patch is about. > Is the above correct? Created attachment 145676 [details, diff]
patch to npw-config.c, to prevent segfaults crashing app
0001 Added test for allocation of 'dirs' array in function get_mozilla_plugin_dirs()
0002 Added function process_entry()
0003 Added prototype for function process_entry()
0004 Simplifed function process_plugin_dir() with functionality delegated to process_entry()
previous implementation of process_plugin_dir() had unchecked allocs and leaks memory if realloc fails
0005 rewrote is_wrapper_plugin() to fork a child for plugin library testing, thus preventing segfaulting libraries from crashing the app
Created attachment 145677 [details, diff]
patch to npw-viewer.c, to prevent segfaults crashing app
0001 fork a child for plugin library testing, thus preventing segfaulting libraries from crashing the app
I see... apparently this doesn't belong here but upstream; please forward similar huge patchsets there, we can't maintain this. Created attachment 145678 [details, diff]
patch to nspluginwrapper-0.9.91.5-r1.ebuild to update to nspluginwrapper-0.9.91.5-r3.ebuild
adds two new patches to nspluginwrapper-0.9.91.5-r1.ebuild
I've forwarded this on to the developer listed on the contact page for nspluginwrapper project. Is there any thing I can do to make it easier for you guys to accept patches, as I modify quite a bit of the code I run. I've forwarded this on to the developer listed on the contact page for nspluginwrapper project. Is there any thing I can do to make it easier for you guys to accept patches, as I modify quite a bit of the code I run. Generally we try to keep as close to upstream as possible, as maintaining large packages is not something that we have time to do. You could become a Gentoo developer and maintain co-maintain projects that you have large patchsets for. You could also feel fork the project and maintain your own releases, we would be willing to include a separate project with a well defined maintainer. I've received no reply from the upstream developer, I don't really have the time to take on an other project, as it is, I'm involved with another open source project that I'm not spending enough time. (In reply to comment #11) > Generally we try to keep as close to upstream as possible, as maintaining large > packages is not something that we have time to do. > > You could become a Gentoo developer and maintain co-maintain projects that you > have large patchsets for. > > You could also feel fork the project and maintain your own releases, we would > be willing to include a separate project with a well defined maintainer. > Your ebuild works, but running nspluginwrapper -v -i /usr/lib32/nsbrowser/plugins/libflashplayer.so doesn't install the plugin on my machine. nspluginwrapper with these patches applied will not allow flash player to be installed. nspluginwrapper -i -v as in the comment above doesn't report anything, failed or otherwise. Using the -u option it yeilds the following... "nspluginwrapper: /usr/lib32/nsbrowser/plugins/libflashplayer.so is not a valid nspluginwrapper plugin" It is a valid file, it works with the pre-patched version (though it crashes often) but it will not install with the patched version. Please try to convince upstream to take these. |