Summary: | [PATCH] app-portage/elogv enhancement | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michał Kiedrowicz <esqualante> |
Component: | Current packages | Assignee: | Christian Faulhammer (RETIRED) <fauli> |
Status: | RESOLVED UPSTREAM | ||
Severity: | enhancement | CC: | lucamarturana |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
elogv patch
elogv-tags.patch |
Description
Michał Kiedrowicz
2008-03-04 23:24:58 UTC
Created attachment 145313 [details, diff]
elogv patch
Will have a deeper look the next days. Thanks in advance anyway. Created attachment 145350 [details]
elogv-tags.patch
Hi, I've already answered your email on 29 feb. Anyway I liked much the idea, I've just changed two things:
1) the star is displayed in bold
2) I've modified the get_class method to be more compact and, I think, faster.
There is my version attached here, I will apply this on the svn version soon. It will be out on the next major release 0.7.
Regards, Luca
(In reply to comment #3) > There is my version attached here, I will apply this on the svn version soon. > It will be out on the next major release 0.7. Any date yet? I will go stable elogv soon (because of the annoying bugs still present in the current stable version) anyway. So I will not apply your patch, Michał, as upstream is aware and active. (In reply to comment #3) > Hi, I've already answered your email on 29 feb. Sorry, but I haven't got it. > Anyway I liked much the idea, Great :-). > I've just changed two things: > > 1) the star is displayed in bold > 2) I've modified the get_class method to be more compact and, I think, faster. > Yeah, looks better. However, I have 2 questions (as I've stated I'm a python newbie): 1. Shouldn't f be closed after f.read()? 2. I've searched manuals regarding elog and einfo and I found elog more severe (it's logged by default and einfo isn't), so shouldn't elog be higher than einfo? (In reply to comment #4) > So I will not apply your patch, Michał, as upstream is aware and active. > It's even better :-). (In reply to comment #5) > 2. I've searched manuals regarding elog and einfo and I found elog more severe > (it's logged by default and einfo isn't), so shouldn't elog be higher than > einfo? Yes, it is. (In reply to comment #4) > Any date yet? I will go stable elogv soon (because of the annoying bugs still > present in the current stable version) anyway. No, I want to do other things and tests before releasing a new major version, not so far though. For now the most stable is the latest 0.6.* Usually I correct bugs with a minor version (for ex 0.6.*), released immediately, and add new features in a major version (for ex 0.7). >(In reply to comment #5) > > Yeah, looks better. However, I have 2 questions (as I've stated I'm a python > newbie): > 1. Shouldn't f be closed after f.read()? > 2. I've searched manuals regarding elog and einfo and I found elog more severe > (it's logged by default and einfo isn't), so shouldn't elog be higher than > einfo? > 1. I don't know if it's necessary in this case, anyway I've added f.close() too. 2. Ok, star tags will be displayed with this alarm level scale then: error, warn, log, info. The svn trunk is now updated with all these notes. Thank you for the help. ;) |