| Summary: | [gnome-experimental] wrong deps for gnome-base/gvfs gphoto2 USE flag | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Priit Laes (IRC: plaes) <plaes> |
| Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | fixed dependencies | ||
|
Description
Priit Laes (IRC: plaes)
2008-02-28 06:27:54 UTC
Created attachment 145615 [details]
fixed dependencies
changed dependecies:
I require dev-libs/libcdio-0.79 and media-gfx/gphoto2-2.4.0 for build it correctly . media-libs/libgphoto2 is a dependency of gphoto2 but I didn't try to build gvfs without gphoto2.
Andrea, a couple things : 1) Please attach patches instead of full ebuilds, it's easier for us to review your changes. 2) You changed a whole lot of things that were perfectly fine in the ebuild and that will break with your version. For instance, you force the glib version to 2.15.6 for no reason at all, glib versions are supposed to be forward compatible. And for a bunch of similar reasons, your changes are wrong. Dependencies should not be based on what is available in portage but what the configure script says. Sorry to sound so blunt :) Anyway, fixed in overlay, configure.ac says only libgphoto2 is needed. Unbelievable, I changed a few lines and I screwed up everything! :( Don't sweat it, ebuilds are not as simple as they seem ;) That's also why we request patches rather than plain ebuilds. It makes reviewing easier for us, but also for you. Thanks for trying anyway :) |
