Summary: | x11-misc/fspanel-0.8_beta1-r2 does not compile with --as-needed | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Thomas Kahle (RETIRED) <tomka> |
Component: | New packages | Assignee: | Desktop Misc. Team <desktop-misc> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | coldwind, idl0r |
Priority: | High | ||
Version: | 2007.0 | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 129413 | ||
Attachments: |
Patch for configure script to make it compile
Patch for the ebuild configure.patch fspanel-0.8_beta1-r2.ebuild.patch fspanel-0.8_beta1-configure.patch |
Description
Thomas Kahle (RETIRED)
2008-02-18 21:03:30 UTC
Created attachment 144167 [details, diff]
Patch for configure script to make it compile
Here is a patch to make it work.
Created attachment 144168 [details, diff]
Patch for the ebuild
And here is a patch for the ebuild to apply the above ...
Some time has passed. Did anyone read this ? Anything wrong with this patch ? Or is there just nobody who cares about this package ? Thomas, we care (or at least I do), I'm a bit busy lately but I'll look into it when I can. Thanks for the patch. This patch does not look right: - it patches configure (which is not good because it's an autogenerated file); - it doesn't fix the issue but just adds a second mistake (passing ldflags after the libraries) that hides the first one (passing libraries before object files). Created attachment 174504 [details, diff]
configure.patch
Created attachment 174506 [details, diff]
fspanel-0.8_beta1-r2.ebuild.patch
here are two patches which should solve the issue.
(In reply to comment #5) > This patch does not look right: > > - it patches configure (which is not good because it's an autogenerated file); in thise case it isn't autogenerated so i think the best way is to patch the self-written configure script. Created attachment 174551 [details, diff] fspanel-0.8_beta1-configure.patch For reference, that's the applied patch. Fix --as-needed (Gentoo bug #210624), X11 path, don't strip binary, use pkg-config for Xft, and avoid automagic deps on Xpm and Xft. It might not be valid for upstream (since I suspect the pkg-config and freetype thing might break compatibility with other platforms) but it's good enough for Gentoo supported arches. Fixed. +*fspanel-0.8_beta1-r3 (07 Dec 2008) + + 07 Dec 2008; Santiago M. Mola <coldwind@gentoo.org> + +files/fspanel-0.8_beta1-configure.patch, +fspanel-0.8_beta1-r3.ebuild: + Fix --as-needed (bug #210624, thanks to Christian Ruppert), X11 path, + don't strip binary, use pkg-config for Xft, and avoid automagic deps on + Xpm and Xft. + Please, test it and bug me in a month for stabilization ;-) Thomas, thanks for reporting and the patch, and sorry for the delay. |