Summary: | dev-util/svnmailer-1.0.8-r1 does not work with dev-lang/python-2.5* | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Tais P. Hansen <tais.hansen> |
Component: | New packages | Assignee: | Andrew Ross (RETIRED) <aross> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | arne_bab, coldwind, mephinet |
Priority: | High | ||
Version: | 2007.0 | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.freebsd.org/cgi/query-pr.cgi?pr=116914 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 148333 | ||
Attachments: | Make svnmailer work under python-2.5, but breaks backwards compatibility. |
Description
Tais P. Hansen
2008-02-12 15:31:33 UTC
Created attachment 143318 [details, diff]
Make svnmailer work under python-2.5, but breaks backwards compatibility.
As far as I can tell the patch is compatible with Python 2.4. I assumed it would break under python-2.4 because exceptions where no longer imported. Why was the import there in the first place then? python-2.3 remnants? Yep, it comes probably from 2.3. In 2.4 both encodings.exceptions.LookupError and LookupError exists. Does the patch break python 2.3 compatibility (Python 2.3 is in portage) Could it in that case just be applied conditionally (only if python 2.4/2.5 is installed)? (In reply to comment #5) > Does the patch break python 2.3 compatibility (Python 2.3 is in portage) No, LookupError is also part of python2.3's global namespace. For the infidels: $ python2.3 -c "print LookupError" exceptions.LookupError $ python2.4 -c "print LookupError" exceptions.LookupError $ python2.5 -c "print LookupError" <type 'exceptions.LookupError'> So please, go ahead. committed -r2 with patch Cool! Many thanks! |