Bug 207647

Summary:	net-dialup/openadsl-4.0.24 does not compile with kernel 2.6.24
Product:	Gentoo Linux	Reporter:	Brian Beardall <brian>
Component:	[OLD] Core system	Assignee:	Gentoo Dialup Developers <net-dialup>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	compile failure on 2.6.24 kernel The diff to make the module compile against the 2.6.24 kernel New openadsl ebuild pulsar.c patch

Description Brian Beardall 2008-01-27 05:19:46 UTC

Compile failure with sa_interrupt undefined, and slub seems to not be compatible with the driver as it leads to a system freeze if using slub when establishing a connection.

Comment 1 Jakub Moc (RETIRED) gentoo-dev

2008-01-27 09:18:29 UTC

Please, post the errors instead of describing them.

Comment 2 Brian Beardall 2008-01-27 17:13:14 UTC

Created attachment 141901 [details]
compile failure on 2.6.24 kernel

Comment 3 Brian Beardall 2008-01-27 17:13:47 UTC

The compile failure has been included now.

Comment 4 Jakub Moc (RETIRED) gentoo-dev

2008-01-27 17:16:38 UTC

/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24/pulsar.c: In function 'pulsar_init_one':
/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24/pulsar.c:1018: error: 'SA_SHIRQ' undeclared (first use in this function)
/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24/pulsar.c:1018: error: (Each undeclared identifier is reported only once
/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24/pulsar.c:1018: error: for each function it appears in.)
/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24/pulsar.c: In function 'pulsar_init':
/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24/pulsar.c:1229: warning: 'pci_find_device' is deprecated (declared at include/linux/pci.h:492)
/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24/pulsar.c: In function 'pulsar_exit':
/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24/pulsar.c:1253: warning: 'pci_find_device' is deprecated (declared at include/linux/pci.h:492)
make[2]: *** [/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24/pulsar.o] Error 1
make[1]: *** [_module_/var/tmp/portage/net-dialup/openadsl-4.0.24/work/pulsar-4.0.24] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.24-gentoo'
make: *** [default] Error 2
 * 
 * ERROR: net-dialup/openadsl-4.0.24 failed.

Comment 5 Brian Beardall 2008-01-29 01:16:09 UTC

Created attachment 142066 [details]
The diff to make the module compile against the 2.6.24 kernel

Comment 6 Brian Beardall 2008-01-29 01:55:23 UTC

Below is the new ebuild, and patch. Please submit to portage.

Comment 7 Brian Beardall 2008-01-29 01:56:46 UTC

Created attachment 142070 [details]
New openadsl ebuild

Comment 8 Brian Beardall 2008-01-29 01:58:01 UTC

Created attachment 142071 [details, diff]
pulsar.c patch

copy the patch to the ${FILESDIR}. ;)

Comment 9 Brian Beardall 2008-01-29 01:59:56 UTC

*** Bug 206359 has been marked as a duplicate of this bug. ***

Comment 10 Alin Năstac (RETIRED) gentoo-dev

2008-01-29 11:45:29 UTC

Fixed in cvs, without revision bump.