| Summary: | net-dialup/slmodem-2.9.11-20070813 doesn't compile with kernel 2.6.24 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Markus Rathgeb <maggu2810> |
| Component: | New packages | Assignee: | Gentoo Developers for the x86 Architecture <x86> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dcecchin, dliana, net-dialup, sven.koehler |
| Priority: | High | Keywords: | STABLEREQ |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 207383 | ||
|
Description
Markus Rathgeb
2008-01-26 14:42:33 UTC
Fixed in slmodem-2.9.11_pre20080126. Thanks! This bug will remain open till this version of slmodem will be stabilized on x86. I'm having trouble compiling this.
* Preparing ungrab-winmodem module
make modules -C /lib/modules/2.6.24-gentoo/build M=/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20080126/work/ungrab-winmodem-20070505
make[1]: Entering directory `/usr/src/linux-2.6.24-gentoo'
CC [M] /var/tmp/portage/net-dialup/slmodem-2.9.11_pre20080126/work/ungrab-winmodem-20070505/ungrab-winmodem.o
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20080126/work/ungrab-winmodem-20070505/ungrab-winmodem.c: In function ‘softmodem_release_init’:
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20080126/work/ungrab-winmodem-20070505/ungrab-winmodem.c:94: error: implicit declaration of function ‘pci_find_device’
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20080126/work/ungrab-winmodem-20070505/ungrab-winmodem.c:94: warning: assignment makes pointer from integer without a cast
make[2]: *** [/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20080126/work/ungrab-winmodem-20070505/ungrab-winmodem.o] Error 1
make[1]: *** [_module_/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20080126/work/ungrab-winmodem-20070505] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.24-gentoo'
make: *** [all] Error 2
*
* ERROR: net-dialup/slmodem-2.9.11_pre20080126 failed.
* Call stack:
* ebuild.sh, line 1701: Called dyn_compile
* ebuild.sh, line 1039: Called qa_call 'src_compile'
* ebuild.sh, line 44: Called src_compile
* slmodem-2.9.11_pre20080126.ebuild, line 74: Called linux-mod_src_compile
* linux-mod.eclass, line 519: Called die
* The specific snippet of code:
* emake HOSTCC="$(tc-getBUILD_CC)" CC="$(get-KERNEL_CC)" LDFLAGS="$(get_abi_LDFLAGS)" \
* ${BUILD_FIXES} ${BUILD_PARAMS} ${BUILD_TARGETS} \
* || die "Unable to make ${BUILD_FIXES} ${BUILD_PARAMS} ${BUILD_TARGETS}."
* The die message:
* Unable to make KERNEL_DIR=/lib/modules/2.6.24-gentoo/build all.
The only thing I see about pci_find_device is this warning: ungrab-winmodem.c:83: warning: ‘pci_find_device’ is deprecated (declared at include/linux/pci.h:480) Do you still have this function defined in /usr/src/linux/include/linux/pci.h? I've worked out what the problem was, I had CONFIG_PCI_LEGACY disabled. "Say Y here if you want to include support for the deprecated pci_find_slot() and pci_find_device() APIs. Most drivers have been converted over to using the proper hotplug APIs, so this option serves to include/exclude only a few drivers that are still using this API." This is obviously one such driver. Perhaps either a patch should be made to make it not use the legacy system, or the ebuild checks to see what CONFIG_PCI_LEGACY is set to and if it is no issue a more informative error like "please enable CONFIG_PCI_LEGACY" and then recompile. done x86 team, please mark net-dialup/slmodem-2.9.11-20070813 as stable. (In reply to comment #1) > Fixed in slmodem-2.9.11_pre20080126. Thanks! > > This bug will remain open till this version of slmodem will be stabilized on > x86. (In reply to comment #7) > x86 team, please mark net-dialup/slmodem-2.9.11-20070813 as stable. I am confused: 08 Jan 2008; Markus Meier <maekke@gentoo.org> slmodem-2.9.11_pre20070813.ebuild: x86 stable, bug #204191 My mistake. Please mark *slmodem-2.9.11_pre20080126* stable. x86 stable, closing as we are last one |
