Summary: | sys-power/hibernate-script auto network up and kde (xstatus) enhancement | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Pete Black <theblackpeter> |
Component: | New packages | Assignee: | Alon Bar-Lev (RETIRED) <alonbl> |
Status: | RESOLVED UPSTREAM | ||
Severity: | enhancement | CC: | mobile+disabled |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
network auto up and kdialog fix
network auto up and kdialog fix |
Description
Pete Black
2008-01-20 22:21:18 UTC
Created attachment 141404 [details, diff]
network auto up and kdialog fix
Created attachment 141405 [details, diff]
network auto up and kdialog fix
Got the dirs mixed up in the previous patch.
Hello, Please submit this to upstream bugzilla... This is unrelated to Gentoo... If upstream accepts this, please open a bug here... Just a few comments... 1. Split patches according to functionality, this patch should be splitted into three... One for networking, one for dcop and the other for kde icon. Each should have its own feature request bug at upstream. 2. By adding network_if_is_up only for Gentoo, you broke all none Gentoo distributions... This is not valid. 3. I am not sure the kde fix is needed, I remember some discussion about this in the past. (In reply to comment #3) > Hello, Hi Alon, > Please submit this to upstream bugzilla... This is unrelated to Gentoo... If > upstream accepts this, please open a bug here... Done so, haven't heard back from anyone. > Just a few comments... > 1. Split patches according to functionality, this patch should be splitted into > three... One for networking, one for dcop and the other for kde icon. Each > should have its own feature request bug at upstream. Yes, you're right. > 2. By adding network_if_is_up only for Gentoo, you broke all none Gentoo > distributions... This is not valid. That's why i posted it here. > 3. I am not sure the kde fix is needed, I remember some discussion about this > in the past. OK, I'll look in to that. Appreciate your input. At least someone cares about the fine details ;) Thanks, Pete |