| Summary: | sys-kernel/kerneloops-0.10 - missing dependency on x11-libs/libnotify | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Peter Gantner (a.k.a. nephros) <gentoo> |
| Component: | New packages | Assignee: | Greg Kroah-Hartman (RETIRED) <gregkh> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | CC: | goric, gurligebis, jm.leddy, kanelxake, kdvgent, michal.terepeta, phajdan.jr, toralf |
| Priority: | High | ||
| Version: | 2007.0 | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
build log showing the exact error
the patch for makefile the patch for ebuild The exact error, kerneloops-0.11 kerneloops-makefile.patch kerneloops-0.11.ebuild.patch |
||
|
Description
Peter Gantner (a.k.a. nephros)
2008-01-19 16:18:29 UTC
ugh, libnotify? I'll add it to the list of dependancies for the next release, but is this really needed if you don't build the X portion of the package? I had and have USE="-gtk" set for kerneloops, and can still reproduce this by unmerging libnotify and trying to emerge kerneloops. I think the reason is that even "make kerneloops" (which is called with USE="-gtk") will execute pkg-config (lines 21,22 in the Makefile). But I'm not very good at reading Makefiles, so that might be wrong. Created attachment 141442 [details]
build log showing the exact error
(In reply to comment #2) > I had and have USE="-gtk" set for kerneloops, and can still reproduce this by > unmerging libnotify and trying to emerge kerneloops. > > I think the reason is that even "make kerneloops" (which is called with > USE="-gtk") will execute pkg-config (lines 21,22 in the Makefile). > > But I'm not very good at reading Makefiles, so that might be wrong. You're almost right - it is about the line 14 in the Makefile, where MY_CFLAGS is defined by calling pkg-config with libnotify and gtk+-2.0 as arguments. Therefore even "make kerneloops" will fail if there is no libnotify and gtk-2.0 on the system. I'm not sure if that is the correct way to do it, but simply changing a bit the the above mentioned line solved the problem for me. I'm attaching a patch for the makefile and for the ebuild. Created attachment 143246 [details, diff]
the patch for makefile
Created attachment 143247 [details, diff]
the patch for ebuild
That kind of patch will not work as we shouldn't be changing the makefile like this as it will break the "normal" build. I'm wondering if this is even possible, can you look at the 0.11 release and see if that works better? (In reply to comment #7) > That kind of patch will not work as we shouldn't be changing the makefile like > this as it will break the "normal" build. > > I'm wondering if this is even possible, can you look at the 0.11 release and > see if that works better? > Unfortunately it still fails. I will attach a log with the exact error. But it is easy to notice that during compilation "pkg-config --cflags libnotify gtk+-2.0" is called and as I do not have the libnotify installed, pkg-config can't find it and fails. Created attachment 151371 [details]
The exact error, kerneloops-0.11
*** Bug 222419 has been marked as a duplicate of this bug. *** Easy found problem in the Makefile:
.c.o wants:
$(CC) $(CFLAGS) $(MY_CFLAGS) -c -o $@ $<
but as:
MY_CFLAGS := `pkg-config --cflags libnotify gtk+-2.0`
then it tries to find libnotify and gtk+-2.0 no matter what...
Created attachment 157705 [details, diff]
kerneloops-makefile.patch
Here is my suggested Makefile patch, which should not break normal (+gtk) builds.
It looks like it could be quite easily adopted by upstream.
Created attachment 157707 [details, diff]
kerneloops-0.11.ebuild.patch
And here is a patch for the ebuild (please note changes in dependencies).
(In reply to comment #13) > Created an attachment (id=157707) [edit] > kerneloops-0.11.ebuild.patch > > And here is a patch for the ebuild (please note changes in dependencies). > Now it gives : claration -Wdeclaration-after-statement `pkg-config --cflags glib-2.0 dbus-glib-1` -c -o submit.o submit.c Package dbus-glib-1 was not found in the pkg-config search path. Perhaps you should add the directory containing `dbus-glib-1.pc' to the PKG_CONFIG_PATH environment variable No package 'dbus-glib-1' found Package dbus-glib-1 was not found in the pkg-config search path. Perhaps you should add the directory containing `dbus-glib-1.pc' to the PKG_CONFIG_PATH environment variable No package 'dbus-glib-1' found kerneloops.c:34:18: error: glib.h: No such file or directory (In reply to comment #14) > Package dbus-glib-1 was not found in the pkg-config search path. Oh, I forgot to add dev-libs/dbus-glib to DEPEND. Thanks for noticing! (In reply to comment #15) > (In reply to comment #14) > > Package dbus-glib-1 was not found in the pkg-config search path. > > Oh, I forgot to add dev-libs/dbus-glib to DEPEND. Thanks for noticing! > yep, now it compiles and installs fine argh, this is just a mess now. I've commited the 0.12 version and took out -gtk support. If someone can create a 0.12 ebuild with the needed changes for this, and if someone wants it, please create a new bug and assign it to me with it. (In reply to comment #17) > argh, this is just a mess now. I've commited the 0.12 version and took out > -gtk support. > > If someone can create a 0.12 ebuild with the needed changes for this, and if > someone wants it, please create a new bug and assign it to me with it. > donezo: bug 276412 |
