Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 205278

Summary: media-libs/libdvdcss: Patch from xine for adding support for network dvd drives
Product: Gentoo Linux Reporter: sam logen <starz909>
Component: New packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED WONTFIX    
Severity: enhancement    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: xine's network patch, modified by me for version change
patch for libdvdcss to support network dvd drives

Description sam logen 2008-01-11 06:26:53 UTC
Hi, as requested I'm starting a new bug report topic on adding a patch for libdvdcss, originally written by xine developers to be compatible with version 1.2.6 of libdvdcss.  I altered the patch file to be compatible with version 1.2.9.

The purpose for this patch is to allow xine and its frontends to play dvds on remote servers with the 'cdda_server' running on the host machine.  This patch is for libdvdcss on the Client machine.  Some people may not be interested in patching the build, so I think it should only be patched if a specific use flag is set.  I only just learned how to make local overlays and add new patches to existing ebuilds, so I do not know how to add USE flags to an ebuild.

  I gave the patched libdvdcss build a short test, and verified it works on a pentium-m processor unit using kaffeine and the latest stable gentoo ebuilds of xine.

If anyone else is willing to make a USE flag that will enable this patch during compile time, please do so.

For reference, documentation in 'xine-lib' under doc/README.network_dvd


Reproducible: Always
Comment 1 sam logen 2008-01-11 06:29:36 UTC
Created attachment 140659 [details, diff]
xine's network patch, modified by me for version change
Comment 2 Alexis Ballier gentoo-dev 2008-01-11 19:03:41 UTC
nice work !

could you please send the patch upstream ? they are the ones the most able to review / proof check the patch and then it will be included for every libdvdcss user
Comment 3 sam logen 2008-01-12 07:31:11 UTC
(In reply to comment #2)
> nice work !
> 
> could you please send the patch upstream ? they are the ones the most able to
> review / proof check the patch and then it will be included for every libdvdcss
> user
> 

Thank you for the compliment.  I'm really new at this, so I'm not sure where you want me to send the patch.  Can you elaborate please?

Sam
Comment 4 Alexis Ballier gentoo-dev 2008-01-12 11:15:19 UTC
(In reply to comment #3)

> 
> Thank you for the compliment.  I'm really new at this, so I'm not sure where
> you want me to send the patch.  Can you elaborate please?

that would probably be on the libdvdcss-devel mailing list. you can subscribe from there: http://www.videolan.org/developers/lists.html
Comment 5 sam logen 2008-01-18 12:05:06 UTC
Created attachment 141215 [details, diff]
patch for libdvdcss to support network dvd drives

OK, done.  I sent a newer patch upstream.  I'm also including the newer patch here just in case those upstream approve it w/o modification.

Sam
Comment 6 sam logen 2008-01-29 23:07:50 UTC
It appears that communications on the libdvdcss-devel mailing list is dead.  I've waited weeks for a reply, and none have replied.  What should I do now?

Sam
Comment 7 Steve Dibb (RETIRED) gentoo-dev 2009-03-10 18:52:44 UTC
(In reply to comment #4)
> (In reply to comment #3)
> 
> > 
> > Thank you for the compliment.  I'm really new at this, so I'm not sure where
> > you want me to send the patch.  Can you elaborate please?
> 
> that would probably be on the libdvdcss-devel mailing list. you can subscribe
> from there: http://www.videolan.org/developers/lists.html
> 

Are VLC devs maintaining the lib now?  I might try poking them on their ML. (not in contact with VLC myself, so I have no idea).
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2011-12-30 13:42:39 UTC
OK, so 3 years later and nobody reported this to upstream yet?  Closing then.