Bug 205229 – mail-client/mutt-1.5.16 - wrong Manifest for patch-1.5.16.sidebar.20070704.txt

• Product: Gentoo Linux
• Status: RESOLVED INVALID

[Description gregory smith 2008-01-10 18:18:42 UTC]

Hello,

I recently attempted to build mutt with USE+=sidebar. Digest verification fails
on the sidebar patchfile:

!!! Digest verification failed:
!!! /usr/portage/distfiles/patch-1.5.16.sidebar.20070704.txt
!!! Reason: Filesize does not match recorded size
!!! Got: 52826
!!! Expected: 51103

Looks like quite the interesting patchfile...

$ grep '^diff' /usr/portage/distfiles/patch-1.5.16.sidebar.20070704.txt
diff -N -c -r mutt-1.5.15-orig/buffy.c mutt-1.5.15-patched/buffy.c
diff -N -c -r mutt-1.5.15-orig/buffy.h mutt-1.5.15-patched/buffy.h
diff -N -c -r mutt-1.5.15-orig/color.c mutt-1.5.15-patched/color.c
diff -N -c -r mutt-1.5.15-orig/compose.c mutt-1.5.15-patched/compose.c
diff -N -c -r mutt-1.5.16-orig/curs_main.c mutt-1.5.16-patched/curs_main.c
diff -N -c -r mutt-1.5.16-orig/flags.c mutt-1.5.16-patched/flags.c
diff -N -c -r mutt-1.5.16-orig/functions.h mutt-1.5.16-patched/functions.h
diff -N -c -r mutt-1.5.16-orig/globals.h mutt-1.5.16-patched/globals.h
diff -N -c -r mutt-1.5.16-orig/init.h mutt-1.5.16-patched/init.h
diff -N -c -r mutt-1.5.15-orig/mailbox.h mutt-1.5.15-patched/mailbox.h
diff -N -c -r mutt-1.5.15-orig/Makefile.am mutt-1.5.15-patched/Makefile.am
diff -N -c -r mutt-1.5.16-orig/Makefile.in mutt-1.5.16-patched/Makefile.in
diff -N -c -r mutt-1.5.15-orig/mbox.c mutt-1.5.15-patched/mbox.c
diff -N -c -r mutt-1.5.15-orig/menu.c mutt-1.5.15-patched/menu.c
diff -N -c -r mutt-1.5.15-orig/mutt_curses.h mutt-1.5.15-patched/mutt_curses.h
diff -N -c -r mutt-1.5.16-orig/mutt.h mutt-1.5.16-patched/mutt.h
diff -N -c -r mutt-1.5.16-orig/muttlib.c mutt-1.5.16-patched/muttlib.c
diff -N -c -r mutt-1.5.16-orig/Muttrc mutt-1.5.16-patched/Muttrc
diff -N -c -r mutt-1.5.15-orig/mx.c mutt-1.5.15-patched/mx.c
diff -N -c -r mutt-1.5.16-orig/OPS mutt-1.5.16-patched/OPS
diff -N -c -r mutt-1.5.16-orig/pager.c mutt-1.5.16-patched/pager.c
diff -N -c -r mutt-1.5.16-orig/PATCHES mutt-1.5.16-patched/PATCHES
diff -N -c -r mutt-1.5.15-orig/sidebar.c mutt-1.5.15-patched/sidebar.c
diff -N -c -r mutt-1.5.15-orig/sidebar.h mutt-1.5.15-patched/sidebar.h
diff -N -c -r mutt-1.5.15-orig/imap/imap.c mutt-1.5.15-patched/imap/imap.c
diff -N -c -r mutt-1.5.16-orig/imap/command.c mutt-1.5.16-patched/imap/command.c

Wow. Heaven knows who created this frankenstein. I checked out a few different
mirrors, but they all seem to have the same garbled patch. The proper
patchfile (which passes digest verification) is available here:

http://lunar-linux.org/~tchan/mutt/patch-1.5.16.sidebar.20070704.txt

Thanks for addressing the issue,
Greg


Reproducible: Always

Steps to Reproduce:
1. Emerge mail-client/mutt-1.5.16 with USE+=sidebar.
2. ???
3. Profit.

[Comment 1 Fernando J. Pereda (RETIRED) 2008-01-10 19:38:52 UTC]

Sorry if I'm being slow here, you mean our mirror system mangled that file? Heh, that'd be interesting.

- ferdy

[Comment 2 gregory smith 2008-01-10 21:40:38 UTC]

No idea. Maybe it was just uploaded that way. In any case, the patchfile is
mangled on every mirror I've looked at.

Greg

[Comment 3 Robin Johnson 2008-01-11 08:02:48 UTC]

What mirrors did you look at?
I looked at:
gtlib
oregon
pair
64hosting (32 hours out of date right now)

the filesize on all of them was the correct 51103, with a correct md5sum of e6e1a6e258ec6ce6ee489b0f3ff8e2cf

[Comment 4 gregory smith 2008-01-11 16:22:28 UTC]

Ok, first let me apologize. I was in a rush when I posted originally, and I was spooked by the version numbers in the patchfile. Red herring, sorry for the confusion.

It looks like the problem is really just to do with line-endings. I'm finding two versions of the file across the mirrors:

e6e1a6e258ec6ce6ee489b0f3ff8e2cf  patch-1.5.16.sidebar.20070704.txt (51103 bytes)
23b638d48b757808819fad5be35416ea  patch-1.5.16.sidebar.20070704.txt (52826 bytes)

The first one has proper unix-like line endings, and the second has the dos-like cr/lf line endings. Attached is a list of mirrors that shows which ones have the correct file and which ones have the incorrect file.

Again, sorry for the misleading nature of the original report.

Greg

[Comment 5 gregory smith 2008-01-11 16:22:56 UTC]

Created attachment 140722 [details]
List of checksums for sidebar patch, as found on http/ftp gentoo mirrors.

[Comment 6 Robin Johnson 2008-01-11 23:53:33 UTC]

Please paste your emerge --info, and also check your .wgetrc.
For some reason, you are using text mode for FTP fetches - which is not the standard config.

root@x:/usr/portage/mail-client/mutt # wget 'ftp://gentoo.mirrors.pair.com/distfiles/patch-1.5.16.sidebar.20070704.txt' -O patch-1.5.16.sidebar.20070704.txt-pairftp
--15:51:12--  ftp://gentoo.mirrors.pair.com/distfiles/patch-1.5.16.sidebar.20070704.txt
           => `patch-1.5.16.sidebar.20070704.txt-pairftp'
Resolving gentoo.mirrors.pair.com... 216.92.2.140
Connecting to gentoo.mirrors.pair.com|216.92.2.140|:21... connected.
Logging in as anonymous ... Logged in!
==> SYST ... done.    ==> PWD ... done.
==> TYPE I ... done.  ==> CWD /distfiles ... done.
==> PASV ... done.    ==> RETR patch-1.5.16.sidebar.20070704.txt ... done.
Length: 51,103 (50K) (unauthoritative)

100%[========================================================================================================================================================================================================================>] 51,103        66.90K/s             

15:51:14 (66.75 KB/s) - `patch-1.5.16.sidebar.20070704.txt-pairftp' saved [51103]

[Comment 7 Fernando J. Pereda (RETIRED) 2008-06-07 16:03:15 UTC]

I'm fixing this as INVALID because it looks like a configuration problem.

- ferdy