| Summary: | media-libs/libdvdcss - small syntax issue with libdvdcss-1.2.9-r1 ebuild | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | sam logen <starz909> |
| Component: | New packages | Assignee: | Gentoo Linux bug wranglers <bug-wranglers> |
| Status: | VERIFIED INVALID | ||
| Severity: | trivial | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
Why? It completely doesn't matter where the quoting is closed. (Patches for xine should be submitted upstream.) (In reply to comment #1) > Why? It completely doesn't matter where the quoting is closed. > > (Patches for xine should be submitted upstream.) > Well I didn't know that. The Gentoo Howto on overlays and ebuild files shows the syntax of ebuild files, so I naturally assumed this was a typo, and out of the goodness of my heart, I decided to bring it to people's attention. By the way, what does "Upstream" mean? If that has something to do with the patch I was talking about, it's not for xine. It's FROM xine. I was just curious if anyone wanted people to have the option of enabling the network capability of libdvdcss with the patch from the xine developers. (In reply to comment #2) > (In reply to comment #1) > Well I didn't know that. The Gentoo Howto on overlays and ebuild files shows > the syntax of ebuild files, so I naturally assumed this was a typo, and out of > the goodness of my heart, I decided to bring it to people's attention. Well thanks, but this really isn't a bug. The quoting is there for cases when people put PORTDIR into a path which contains spaces for whatever whacky reason. You can easily test this with something like: foo="/tmp/stupid path with spaces"; mkdir -p "${foo}"; touch "${foo}/foo.txt" foo="/tmp/stupid path with spaces"; mkdir -p "${foo}"; touch "${foo}"/foo.txt and see that the quoting works as expected in both cases. > By the way, what does "Upstream" mean? If that has something to do with the > patch I was talking about, it's not for xine. It's FROM xine. Misunderstood you then. Anyway, a separate bug please, it's completely unrelated to the original topic. |
Hi, I'm not sure if this is problematic, since libdvdcss builds adequately, and no-one has complained, but I think there's a small issue of double-quote placement in the ebuild file. Specifically, line 37, quotes should be "${FILESDIR}"/${P}-latex-character-encoding.patch I noticed this when I went to add xine's network patch to my overlay of libdvdcss. Reproducible: Always If, by the way, anyone is interested in adding xine's network patch to the portage - to support network dvd drives via xine's cdda_server (perhaps as an extra USE flag), let me know, and I'll provide my modified patch (only modified to point to the current version of libdvdcss) and my ebuild file. I tested it with kaffeine on the client machine and it seems to work well. Additional reference in xine-lib's "doc/README.network_dvd" file.