Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 204448

Summary: sys-kernel/linux-headers-2.6.23-r3: L2TP merge breaks compilation against linux/if_ppp* headers
Product: Gentoo Linux Reporter: Aleksey Shipilev <aleksey.shipilev>
Component: [OLD] Core systemAssignee: Gentoo Toolchain Maintainers <toolchain>
Severity: major    
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
Package list:
Runtime testing required: ---
Attachments: Proposed patch

Description Aleksey Shipilev 2008-01-05 16:14:09 UTC
Newly merged L2TP stack in Linux 2.6.23 kernel breaks any package that depends on linux/if_ppp* headers, f.ex. rp-pppoe does.

Reproducible: Always

Steps to Reproduce:
This microtest is derived from what rp-pppoe build system experiencing:

    #include <sys/socket.h>
    #include <net/ethernet.h>
    #include <linux/if.h>
    #include <linux/if_ppp.h>
    #include <linux/if_pppox.h>

    int main(void) {
           return 0;

Actual Results:  
shade@1608-pegasus ~/pppoe/sample $ gcc pppoe-try.c -o pppoe-try
    In file included from /usr/include/linux/if_pppox.h:26,
                     from pppoe-try.c:4:
    /usr/include/linux/if_pppol2tp.h:30: error: field ‘addr’ has incomplete type

Expected Results:  
shade@1608-pegasus ~/pppoe/sample $ gcc pppoe-try.c -o pppoe-try
Comment 1 Aleksey Shipilev 2008-01-05 16:19:30 UTC
Created attachment 140194 [details, diff]
Proposed patch

This patch for gentoo-headers solves the problem. There's a need to consult with kernel hackers how exactly this patch must sound like.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2008-01-05 16:20:36 UTC
Uh, please stop using net-dialup/rp-pppoe for anything. Been deprecated ages ago in favour of ppp and baselayout.
Comment 3 Aleksey Shipilev 2008-01-05 16:29:00 UTC
Thanks, Jakub. 

Unfortunately, there is a need in working PPPoE _server_. AFAIU, your suggestion covers only client-side PPPoE.

Anyway, this issue affect not only the net-dialup/rp-pppoe but any other package depending on mentioned headers.
Comment 4 SpanKY gentoo-dev 2008-01-05 17:48:27 UTC
yeah, dont pay attention to him ... the changes you propose look like a good direction, but you're right that we'll have to post it to lkml and see how others like it
Comment 5 Aleksey Shipilev 2008-01-05 18:12:00 UTC
> but you're right that we'll have to post it to lkml and see how others like it
Ok, should I do that myself, or there is any working process for migrating such the issues to lkml?
Comment 6 SpanKY gentoo-dev 2008-01-05 19:14:02 UTC
i'll post an update later tonight (hopefully)
Comment 7 Aleksey Shipilev 2008-01-08 17:25:04 UTC
SpanKY, any updates?
Comment 8 SpanKY gentoo-dev 2008-01-26 09:31:23 UTC
should be fixed with 2.6.24 headers

please test
Comment 9 Aleksey Shipilev 2008-01-27 17:15:41 UTC
The issue disappeared for this microtest on

...but rp-pppoe compilation fails on another issue. I will open new bug on that.