| Summary: | cvs update failure check in /usr/portage/eclass/cvs.eclass | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Danny Milosavljevic <danny_milo> |
| Component: | New packages | Assignee: | Dan Armak (RETIRED) <danarmak> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | 1.4_rc4 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
btw I think the "false" here is unneccesary, its just to be sure ;) and 'eval $cmdlogin || die "^ error"' could be without error checking because the login can fail, but the update afterwards still work (have already seen that). I suspect this being so because the update logins if neccessary though... oops, bug # 20871 is the current one with a patch... I forgot that I already reported here... sorry ! |
/usr/portage/eclass/cvs.eclass: line 185 should be: if [ "${ECVS_AUTH}" == "pserver" ]; then einfo "Running $cmdlogin" eval $cmdlogin || die "^ error" if [ "${mode}" == "update" ]; then einfo "Running $cmdupdate" eval $cmdupdate || { false die "failed ${cmdupdate}" } elif [ "${mode}" == "checkout" ]; then einfo "Running $cmdcheckout" eval $cmdcheckout || { false die "failed ${cmdcheckout}" } Otherwhise when getting for example "end of file from server" (happens rather often lately on sourceforge), it would continue building and thinking it was successful. Thanks :)