Bug 203400 – Patch to nwn-data-1.29-r2 and nwn-1.68-r2

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Kai Krakow 2007-12-26 22:59:57 UTC]

These both patches incorporate several fixes and enhancements:

1. Support NWN German 3-in-1 DVD
2. Fix detecting UDF formatted media (like German 3-in-1 DVD)
3. Fix loop creating and changing to subdirs but not returning to parent,
   which wrongly creates one language dir in another one
4. Fix incomplete source URI if both HoU and SoU are installed

The "fix" in (1) is just an enhancement and it's detection is not very well tested against other NWN media sets but seems to work (tested by friends).

The fix in (2) fixes the media detection which wasn't able to recognise UDF formatted DVD media.

The fix in (3) fixes installations with more than one languages in LINGUAS. "de" was created within the "en" dir and so forth. Other files later on have gone to worng locations too.

Comparing a friends (Windows) installation and mine, I think the files missing because of (4) are needed to play. I had some segfaults without them.

Reproducible: Always

[Comment 1 Kai Krakow 2007-12-26 23:02:35 UTC]

Created attachment 139370 [details, diff]
Patch to nwn-data-1.29-r2

[Comment 2 Kai Krakow 2007-12-26 23:02:55 UTC]

Created attachment 139372 [details, diff]
Patch to nwn-1.68-r2

[Comment 3 Ian Leonard 2007-12-31 07:45:58 UTC]

(In reply to comment #0)
> 4. Fix incomplete source URI if both HoU and SoU are installed
> 
> Comparing a friends (Windows) installation and mine, I think the files missing
> because of (4) are needed to play. I had some segfaults without them.

Do you know what files were missing? 

Doing a diff on the file listings only reveals differences that should be there.  For example, patch.key versus xp1patch.key versus xp2patch.key, or the expansion modules.  The only files that stand out in the original client tarball against the others are override/itt_medkit_001.tga and override/._itt_medkit_001.tga. As it's just the image file for the medkit, I would think it safe to assume it was rolled into the data files when the release media was updated with the expansions.

Note: These are English tarballs I'm looking at.

[Comment 4 Kai Krakow 2007-12-31 12:59:12 UTC]

(In reply to comment #3)
> Do you know what files were missing? 
> 
> Doing a diff on the file listings only reveals differences that should be
> there.  For example, patch.key versus xp1patch.key versus xp2patch.key, or the
> expansion modules.  The only files that stand out in the original client
> tarball against the others are override/itt_medkit_001.tga and
> override/._itt_medkit_001.tga. As it's just the image file for the medkit, I
> would think it safe to assume it was rolled into the data files when the
> release media was updated with the expansions.
> 
> Note: These are English tarballs I'm looking at.

I used German tarballs. I have to free up some disk space before I can do a file list diff. I could first test if the game runs smoothly now without patch (4) applied. I suppose I had other problems in my installation because of bug (3). You may defer the patch modifying the source URIs (4) until later.

[Comment 5 Denis Dupeyron (RETIRED) 2008-02-16 22:53:34 UTC]

*** Bug 170638 has been marked as a duplicate of this bug. ***

[Comment 6 Denis Dupeyron (RETIRED) 2008-02-17 01:25:00 UTC]

(In reply to comment #4)
> You may defer the patch modifying the source URIs (4) until later.

I have committed your fixes for 1, 2 and 3 in nwn-data-1.29-r3. I'll keep this bug open until we decide something for 4.

Denis.

[Comment 7 Kai Krakow 2008-02-26 15:24:47 UTC]

Patch 4 can be discarded. I removed my NWN installation from hard disk and reinstalled from scratch with the shiny new ebuilds. Works like a charm...