| Summary: | x-modular eclass has incorrect check for non-debuggable modules | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | John W Eckhart <jweckhart> |
| Component: | Eclasses | Assignee: | Gentoo X packagers <x11> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Fix check for what packages are debuggable
Fix check for what packages are debuggable |
||
Created attachment 135906 [details, diff]
Fix check for what packages are debuggable
Created attachment 135907 [details, diff]
Fix check for what packages are debuggable
This patch correctly marks "non-debuggable" items as such, and leaves "debuggable" items alone.
Sweet, thanks! I've known about this for a while but never tracked it down. Applied your patch to CVS. |
The x-modular eclass checks for certain criteria of the ebuilds that inherit it to rule them out as debuggable. For example, fonts, prototypes, docs, etc are not debuggable. However, the check incorrectly uses an || instead of && as it compares various heuristics. Additionally, for docs and prototypes, the eclass incorrectly uses the package name (${PN}) instead of it's category (${CATEGORY}). A patch is attached below. Reproducible: Always Steps to Reproduce: You can verify that the x-modular marks x11-prototypes as debuggable by checking the useflags on a prototype: eix -e x11-proto/xproto Actual Results: [I] x11-proto/xproto Available versions: 7.0.10 {debug} Installed versions: 7.0.10(15:36:01 10/31/07)(-debug) Homepage: http://xorg.freedesktop.org/ Description: X.Org xproto protocol headers Expected Results: [I] x11-proto/xproto Available versions: 7.0.10 Installed versions: 7.0.10(15:36:01 10/31/07) Homepage: http://xorg.freedesktop.org/ Description: X.Org xproto protocol headers Portage 2.1.3.19 (selinux/2007.0/amd64/hardened, gcc-3.4.6, glibc-2.6.1-r0, 2.6.23-pmp-r1 x86_64) ================================================================= System uname: 2.6.23-pmp-r1 x86_64 Intel(R) Core(TM)2 CPU 6300 @ 1.86GHz Timestamp of tree: Tue, 13 Nov 2007 07:58:01 +0000 app-shells/bash: 3.2_p17 dev-java/java-config: 1.3.7, 2.0.33-r1 dev-lang/python: 2.4.4-r6 dev-python/pycrypto: 2.0.1-r6 sys-apps/baselayout: 1.12.9-r2 sys-apps/sandbox: 1.2.18.1-r2 sys-devel/autoconf: 2.13, 2.61-r1 sys-devel/automake: 1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10 sys-devel/binutils: 2.18-r1 sys-devel/gcc-config: 1.3.16 sys-devel/libtool: 1.5.24 virtual/os-headers: 2.6.22-r2 ACCEPT_KEYWORDS="amd64" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=nocona -Os -pipe -fomit-frame-pointer" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/X11/xkb" CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/udev/rules.d" CXXFLAGS="-march=nocona -Os -pipe -fomit-frame-pointer" DISTDIR="/usr/portage/distfiles" FEATURES="collision-protect distlocks loadpolicy metadata-transfer parallel-fetch sandbox selinux sesandbox sfperms strict unmerge-orphans userfetch userpriv usersandbox" GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo" MAKEOPTS="-j4" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/portage/local/layman/vmware /usr/portage/local/my_overlay" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="X X509 acpi alsa amd64 avahi bash-completion berkdb bitmap-fonts branding bzip2 cairo cdr cli cracklib crypt cups d dbus dri dvdr expat fam firefox fortran gcj gdbm glitz gnome gpm gstreamer gtk gtkhtml hal hardened hpn iconv ipv6 isdnlog java javascript jpeg keyring libnotify logrotate midi mmx mng mozilla mudflap ncurses nfs nls nptl nptlonly nsplugin opengl openmp pam pcre perl pic png pppd python readline reflection samba seamonkey selinux session spl sqlite sqlite3 sse sse2 ssl tcpd tiff truetype truetype-fonts type1-fonts unicode usb xcb xforms xml xorg xpm xprint xulrunner xv zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="i810 fbdev vesa vga" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS