Bug 198868

Summary:	net-wireless/iwlwifi-1.1.21: LED not working
Product:	Gentoo Linux	Reporter:	Jonathan Thibault <cuvier>
Component:	New packages	Assignee:	Saleem Abdulrasool (RETIRED) <compnerd>
Status:	RESOLVED WONTFIX
Severity:	enhancement	CC:	ischram, mobile+disabled
Priority:	High
Version:	unspecified
Hardware:	x86
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch to iwlwifi sources to enable led on iwl3945 modded ebuild that uses the patch

Description Jonathan Thibault 2007-11-11 22:02:38 UTC

There is no LED support in iwlwifi yet.  A patch was released on one of their mailing list some time ago (for iwlwifi-1.1.17 I think).  I've hacked together an adaptation of the patch for the current version on iwl3945.  It should be fairly easy to do the same with iwl4965, but I have no such hardware to test it.  My iwl3945 LED works fine now thanks to this patch, I just wanted to share it in the hopes better coders could implement it right.  There is probably some function renaming to be done and what not before it can be fed upstream to the iwlwifi project.

Reproducible: Always

Steps to Reproduce:
Load the module, no LED.
Associate, no LED.
Produce activity on the wireless link, no LED...
Actual Results:  
No LED?

Expected Results:  
LED.

1- This patch only works for iwl3945, I haven't applied it to iwl4965.
2- It based on the code of some other dev.  Whoever you are, take credit!  I just got a patch off the kamikaze sources and messed with it 'till it worked.
3- It probably still needs work.

Comment 1 Jakub Moc (RETIRED) gentoo-dev

2007-11-11 22:04:49 UTC

Get this accepted upstream, please.

Comment 2 Jonathan Thibault 2007-11-11 22:05:32 UTC

Created attachment 135772 [details, diff]
patch to iwlwifi sources to enable led on iwl3945

Works fine for me but probably still needs work.
Can be adapted to patch iwl4965 too.

Comment 3 Jonathan Thibault 2007-11-11 22:08:08 UTC

Created attachment 135774 [details]
modded ebuild that uses the patch

Just so lazy people like me can download the files, merge and brighten their day with wifi LED goodness.

Comment 4 Ian Schram 2007-11-12 03:35:34 UTC


Please don't use this patch. (I'm pretty sure i'm the one who once hacked this together) but i didn't do a byte for byte comparison. It was just ment to be a quick fix certainly not to be included in portage.
problems with this patch include: energy wasting, won't work when reassociated

I am trying to get support for this upstream.
I have sent a more decent patch to the appropriate mailinglists( http://bugs.gentoo.org/attachment.cgi?id=135772 ) where it wasn't accepted. Basically the intel developer(s) have a better idea. 
even this patch probably shouldn't be used, ... because there are probably other good reasons why it wont be accepted. Please review/test/fix this patch and send your comments to that mailinglist. rather than pushing it through here

Comment 5 Ian Schram 2007-11-12 03:37:04 UTC

sorry copy paste error this was the link i meant to paste

http://www.spinics.net/lists/linux-wireless/msg07118.html

Comment 6 Saleem Abdulrasool (RETIRED) gentoo-dev

2007-11-17 22:54:05 UTC

I agree with Ian, this should actually be pushed upstream.  Marking this as wontfix.