Bug 19812

Summary:	Typo in xfree-4.3.0-r2.ebuild preventing TDFX_RISKY from taking effect
Product:	Gentoo Linux	Reporter:	Qian Wang <qianzw>
Component:	New packages	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED FIXED
Severity:	normal	CC:	x11
Priority:	High
Version:	1.2
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch to make TDFX_RISKY useful

Description Qian Wang 2003-04-22 23:32:00 UTC

There's a typo (# instead of $ in front of a variable) that's preventing the
very useful TDFX_RISKY variable from taking effect.  TDFX_RISKY is related to
bug #15001.  Here's the patch.

--- xfree-4.3.0-r2.ebuild       2003-04-22 23:58:26.000000000 -0400
+++ xfree-4.3.0-r2.ebuild.mine  2003-04-23 00:08:26.000000000 -0400
@@ -204,7 +204,7 @@
  
        if [ "`use 3dfx`" -a "${TDFX_RISKY}" = "yes" ]
        then
-               rm #{WORKDIR}/patch/075*
+               rm -f ${WORKDIR}/patch/075*
        fi
  
        # Various Patches from all over

Comment 1 Qian Wang 2003-04-22 23:33:47 UTC

Created attachment 11028 [details, diff]
patch to make TDFX_RISKY useful

Comment 2 Michael Fitzpatrick 2003-04-23 11:08:38 UTC

Hi Qian, thanks for your patch.

I've got a fix for this, posted to dri-devel months ago which removes the need for patch 075 afaiaa, I'll add that if it hasn't found its way into the xfree4.3 tree.

Comment 3 Michael Fitzpatrick 2003-04-24 15:49:23 UTC

I've applied the patch to xfree-4.3.0-r2 (it's in patches 1.1.3)

The new patch still requires TDFX_RISKY to be set

I'll add the patch as a default in xfree-4.3.0-r3 if it doesn't cause problems.

Comment 4 Seemant Kulleen (RETIRED) gentoo-dev

2003-05-18 03:45:13 UTC

closing