Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 196973

Summary: media-libs/x264-svn creates own CFLAGS variant
Product: Gentoo Linux Reporter: Steve Dibb (RETIRED) <beandog>
Component: New packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED INVALID    
Severity: normal CC: aballier
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: filter flags, use upstream's CFLAGS

Description Steve Dibb (RETIRED) gentoo-dev 2007-10-24 22:23:25 UTC
configure script in media-libs/x264-svn-20070924 uses its own CFLAGS, so we need to decide if we want to override upstreams or use our own or a mix of the two.

if [ "$debug" = "yes" ]; then
    CFLAGS="-O1 -g $CFLAGS"
else
    CFLAGS="-O4 -ffast-math $CFLAGS"
fi

My suggestion is just to run filter-flags on -O? and -ffast-math ... any ideas?
Comment 1 Steve Dibb (RETIRED) gentoo-dev 2007-10-24 22:32:23 UTC
Created attachment 134277 [details, diff]
filter flags, use upstream's CFLAGS
Comment 2 Steve Dibb (RETIRED) gentoo-dev 2007-10-25 00:36:16 UTC
n/m, is all good