Bug 193888 – x11-libs/motif-config - motif-config overwrites files it doesn't own

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jeroen Roovers (RETIRED) 2007-09-26 17:44:45 UTC]

See the last few comments in bug #183736.

Setting a new motif profile (using, say, `motif-config -s openmotif-2.3`) sets symlinks in /usr/bin, possibly overwriting executables from other packages with links to /usr/lib/openmotif-2.3.

[Comment 1 Jeroen Roovers (RETIRED) 2007-09-26 17:56:29 UTC]

Index: files/motif-config-0.10
===================================================================
RCS file: /var/cvsroot/gentoo-x86/x11-libs/motif-config/files/motif-config-0.10,v
retrieving revision 1.1
diff -u -B -r1.1 motif-config-0.10
--- files/motif-config-0.10     20 Feb 2006 10:24:02 -0000      1.1
+++ files/motif-config-0.10     26 Sep 2007 17:56:04 -0000
@@ -84,14 +84,6 @@
                ln -s /usr/include/${new}/${file} /usr/include/${file}
                retval=$((retval | $? ))
        done
-       # binaries
-       for file in `ls /usr/@@LIBDIR@@/${new} | grep -v lib`; do
-               files="${files} /usr/bin/${file}"
-               rm -rf /usr/bin/${file}
-               retval=$((retval | $? ))
-               ln -s /usr/@@LIBDIR@@/${new}/${file} /usr/bin/${file}
-               retval=$((retval | $? ))
-       done
        # man pages
        for file in `find /usr/share/man -regex ".*-${new}\..x?.gz"`; do
                files="${files} ${file/-${new}/}"
Index: files/motif-config-0.9
===================================================================
RCS file: /var/cvsroot/gentoo-x86/x11-libs/motif-config/files/motif-config-0.9,v
retrieving revision 1.1
diff -u -B -r1.1 motif-config-0.9
--- files/motif-config-0.9      26 Apr 2005 13:56:50 -0000      1.1
+++ files/motif-config-0.9      26 Sep 2007 17:56:04 -0000
@@ -79,12 +79,6 @@
                rm -f /usr/include/${file}
                ln -s /usr/include/${new}/${file} /usr/include/${file}
        done
-       # binaries
-       for file in `ls /usr/@@LIBDIR@@/${new} | grep -v lib`; do
-               files="${files} /usr/bin/${file}"
-               rm -f /usr/bin/${file}
-               ln -s /usr/@@LIBDIR@@/${new}/${file} /usr/bin/${file}
-       done
        # man pages
        for file in `find /usr/share/man -regex ".*-${new}\..x?.gz"`; do
                files="${files} ${file/-${new}/}"

[Comment 2 Jeroen Roovers (RETIRED) 2007-09-26 18:22:37 UTC]

I committed these changes and forced a rebuild for both stable (0.9) and testing (0.10) ebuilds through a revbump, but now we will need to decide which useful executables get to stay in /usr/bin. I vote for mwm and xmbind but I am still checking whether lesstif provides these as well.

[Comment 3 Jeroen Roovers (RETIRED) 2007-09-26 18:41:27 UTC]

uil is the third and final executable that has a place in /usr/bin, IMHO.

[Comment 4 Jeroen Roovers (RETIRED) 2007-09-26 18:51:22 UTC]

Suggested changes:

Index: files/motif-config-0.10
===================================================================
RCS file: /var/cvsroot/gentoo-x86/x11-libs/motif-config/files/motif-config-0.10,v
retrieving revision 1.2
diff -u -B -r1.2 motif-config-0.10
--- files/motif-config-0.10     26 Sep 2007 18:17:56 -0000      1.2
+++ files/motif-config-0.10     26 Sep 2007 18:50:53 -0000
@@ -84,6 +84,11 @@
                ln -s /usr/include/${new}/${file} /usr/include/${file}
                retval=$((retval | $? ))
        done
+       # executables
+       for file in mwm uil xmbind; do
+               rm -f /usr/bin/${file}
+               ln -s /usr/@@LIBDIR@@/${new}/${file} /usr/bin/${file}
+       done
        # man pages
        for file in `find /usr/share/man -regex ".*-${new}\..x?.gz"`; do
                files="${files} ${file/-${new}/}"
Index: files/motif-config-0.9
===================================================================
RCS file: /var/cvsroot/gentoo-x86/x11-libs/motif-config/files/motif-config-0.9,v
retrieving revision 1.2
diff -u -B -r1.2 motif-config-0.9
--- files/motif-config-0.9      26 Sep 2007 18:17:56 -0000      1.2
+++ files/motif-config-0.9      26 Sep 2007 18:50:53 -0000
@@ -79,6 +79,11 @@
                rm -f /usr/include/${file}
                ln -s /usr/include/${new}/${file} /usr/include/${file}
        done
+       # executables
+       for file in mwm uil xmbind; do
+               rm -f /usr/bin/${file}
+               ln -s /usr/@@LIBDIR@@/${new}/${file} /usr/bin/${file}
+       done
        # man pages
        for file in `find /usr/share/man -regex ".*-${new}\..x?.gz"`; do
                files="${files} ${file/-${new}/}"

[Comment 5 Jeroen Roovers (RETIRED) 2007-09-27 01:45:08 UTC]

Committed those changes as well.