Bug 192676

Summary:	dev-libs/ace-5.9.9 - config.h has several PACKAGE_* defines
Product:	Gentoo Linux	Reporter:	Alin Năstac (RETIRED) <mrness>
Component:	[OLD] Library	Assignee:	Daniel Black (RETIRED) <dragonheart>
Status:	RESOLVED FIXED
Severity:	minor	CC:	cpp+disabled, tantive
Priority:	High
Version:	2007.0
Hardware:	All
OS:	Linux
URL:	http://deuce.doc.wustl.edu/bugzilla/show_bug.cgi?id=3089
Whiteboard:
Package list:		Runtime testing required:	---

Description Alin Năstac (RETIRED) gentoo-dev

2007-09-16 11:32:43 UTC

dev-libs/ace wrongfully install several PACKAGE_* definitions in /usr/include/ace/config.h. Most packages have their own PACKAGE_* definitions which will make compiler to throw redefinition warnings at every C/C++ file that includes <ace/config.h> either directly or indirectly.

Output of grep PACKAGE /usr/include/ace/config.h:
#define PACKAGE_BUGREPORT "ace-bugs@cs.wustl.edu"
#define PACKAGE_NAME "ACE"
#define PACKAGE_STRING "ACE 5.5.9"
#define PACKAGE_TARNAME "ace"
#define PACKAGE_VERSION "5.5.9"

Please remove these definitions in the next revision/version you make. These are meant to be used when ace library is compiled, not when some program is linked against libace.

Comment 1 Alin Năstac (RETIRED) gentoo-dev

2007-10-08 07:18:34 UTC

Daniel, I see you are the active maintainer of ace. Please fix this bug.

Comment 2 Daniel Black (RETIRED) gentoo-dev

2007-10-08 09:02:13 UTC

fixed in stable and latest.

Comment 3 Daniel Black (RETIRED) gentoo-dev

2007-10-08 09:17:17 UTC

added upstream report.

Comment 4 Alin Năstac (RETIRED) gentoo-dev

2008-07-13 13:10:29 UTC

That is not the correct fix. At the end of src_install you should do the following:
          sed -i -e "^#define PACKAGE_.*//g" "${D}"/usr/include/ace/config.h

Currently you run
  sed -i -e "^#define PACKAGE_.*//g" /usr/include/ace/config.h
at the end of src_test, which will trigger a sandbox exception if you try do install it with FEATURES=test.

Comment 5 Alin Năstac (RETIRED) gentoo-dev

2008-12-14 11:57:37 UTC

Fixed in ace-5.6.5-r2.