Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 192168

Summary: toolchain-binutils.eclass dies on failed tests with FEATURES="test"
Product: Gentoo Linux Reporter: Panagiotis Christopoulos (RETIRED) <pchrist>
Component: EclassesAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Status: RESOLVED INVALID    
Severity: normal    
Priority: High    
Version: 2007.0   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Panagiotis Christopoulos (RETIRED) gentoo-dev 2007-09-11 14:51:44 UTC
As gcc's "make check", binutils's " make check" will always fail. The toolchain.eclass, in gcc, handles this issue by doing:

make check || ewarn "check failed and that sucks :("

in gcc_src_test() function, and the emerge process continues.
But the toolchain-binutils.eclass does:

make check || die "check failed :("

in toolchain-binutils_src_test() function, and stops the emerge process.

From my point of view, the latter is wrong, and "die" should be replaced by "ewarn" as happens in toolchain.eclass
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-09-11 15:21:36 UTC
It doesn't break anything, the tests failed if it dies for you. File bugs about broken tests or remove test from your FEATURES.