Bug 190634 – net-im/twinkle (w/ USE=speex) needs >=media-libs/speex-1.2_beta2 w/ USE=wideband

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description David Watzke 2007-08-29 12:29:06 UTC]

net-im/twinkle w/ USE=speex needs >=media-libs/speex-1.2_beta2 w/ USE=wideband, because else twinkle crashes when I try to call (even with speex disabled in the codec options):

Fatal (internal) error: Wideband and Ultra-wideband are disabled

[Comment 1 William Zhou 2007-09-02 00:56:09 UTC]

diff twinkle-1.1* -u
--- twinkle-1.1.ebuild  2007-07-23 10:37:51.000000000 +0100
+++ twinkle-1.1-r1.ebuild       2007-09-02 01:54:25.000000000 +0100
@@ -27,6 +27,13 @@
 DEPEND="${RDEPEND}
        dev-util/pkgconfig"

+pkg_setup() {
+       if ! built_with_use media-libs/speex wideband; then
+               eerror "You need to build media-libs/speex with USE=wideband enabled."
+               die "Speex w/o wideband-support detected."
+       fi
+}
+
 src_unpack() {
        unpack ${A}
        cd "${S}"

[Comment 2 William Zhou 2007-09-02 00:58:04 UTC]

Created attachment 129810 [details]
Patched ebuild.

Add the detection part. Twinkle twinkles now:).

[Comment 3 David Watzke 2007-09-02 07:38:24 UTC]

AFAIK this will fail with older speex versions without wideband flag.

[Comment 4 William Zhou 2007-09-02 12:51:54 UTC]

Created attachment 129830 [details]
Version check with speex now.

Speex-1.2* is required in this ebuild. I haven't tested the 1.1 serious, so I make it a requirement rather than an option.

[Comment 5 David Watzke 2007-09-02 12:57:34 UTC]

OMG. First of all, if you want to depend on speex 1.2*, you should do it in the DEPEND variable. Second: it's nonsense! It works fine with older versions. Use something like:

if has_version '>=media-libs/speex-1.2_beta2' && ! built_with_use 'media-libs/speex' wideband; then
	eerror "You need to build media-libs/speex with USE=wideband"
	die "Speex without wideband-support detected."
fi

[Comment 6 William Zhou 2007-09-02 13:44:21 UTC]

Created attachment 129831 [details]
Updated with speex check.

Sorry, I am new to ebuild. Thanks for the information.

~x86 is used by most of my friends and I assume it is the same as in other places. People who use twinkle tends to be desktop users and most of them use ~x86. So their speex are updated to 1.2*. That's why I didn't tested the 1.1 serious, and I mentioned it too.

Anyway, I updated and hope it works.

[Comment 7 David Watzke 2007-09-02 13:50:21 UTC]

Yeah, but speex 1.2_beta2 is new in here, twinkle 1.1 has been there for a longer time, so I used it with older speex (running ~amd64). Anyway, I suppose that wideband flag will be present from now (1.2_beta2) on, so I don't get why did you changed has_version '>=media-libs/speex-1.2_beta2' as I proposed to '=media-libs/speex-1.2*'.

[Comment 8 William Zhou 2007-09-02 15:20:53 UTC]

I am not familiar with the version expression. So I chose one I understand and it should work for this minor release(speex 1.2*).

[Comment 9 Daniel Black (RETIRED) 2007-09-14 12:02:13 UTC]

*** Bug 191288 has been marked as a duplicate of this bug. ***

[Comment 10 Daniel Black (RETIRED) 2007-09-14 12:08:54 UTC]

thanks David and William.

David - please keep the dramatic language out of bug reports. It just sounds rude. Helpful polite well explained suggestions are the way to go.

[Comment 11 David Watzke 2007-09-14 12:17:04 UTC]

(In reply to comment #10)
> David - please keep the dramatic language out of bug reports. It just sounds
> rude. Helpful polite well explained suggestions are the way to go.

Sure, I'm sorry (William). It won't happen again.

[Comment 12 Daniel Black (RETIRED) 2007-09-14 21:45:36 UTC]

*** Bug 192515 has been marked as a duplicate of this bug. ***