| Summary: | net-firewall/arptables-0.0.3-3 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Olivier Huber <oli.huber> |
| Component: | Current packages | Assignee: | Peter Volkov (RETIRED) <pva> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | richardvoigt |
| Priority: | High | ||
| Version: | 2007.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 162886 | ||
| Attachments: |
My ebuild proposal
patch needed to install the package |
||
|
Description
Olivier Huber
2007-08-23 13:46:34 UTC
Created attachment 128955 [details]
My ebuild proposal
Created attachment 128956 [details, diff]
patch needed to install the package
arptables-0.0.3.3 is in portage. Oliver, just few notes on your (and mine) ebuild: * $WORKDIR should be quoted as it is user defined and may contain spaces there. * I did not understood why do you need multilib eclass there * To install package I just go with dobin and doman functions as there are only three files to be installed and no patches/sed required, but of course your solution works too. * Next time attach into bugzilla diff of ebuild. This clearly tells what chaged and thus easier to review > Oliver, just few notes on your (and mine) ebuild: > * $WORKDIR should be quoted as it is user defined and may contain spaces there. > * I did not understood why do you need multilib eclass there heu ... it was just a mistake : I copy/paste the inherit arguments too fast, without checking if I need all of them > * To install package I just go with dobin and doman functions as there are only > three files to be installed and no patches/sed required, but of course your > solution works too. sure, it was a little bit overkill here > * Next time attach into bugzilla diff of ebuild. This clearly tells what chaged > and thus easier to review > ok I'll do that next time Thanks again |
