|
Description
Arfrever Frehtes Taifersar Arahesis (RETIRED)
2007-08-22 07:55:59 UTC
There is a new dependency - media-libs/ilmbase. Both packages should have LICENSE="ILM". media-libs/ilmbase-1.0.0 was released on 2007-08-04.
media-libs/ctl-1.4.0 was released on 2007-08-03.
media-libs/openexr_ctl-1.0.0 was released on 2007-08-03.
media-libs/openexr_viewers-1.0.0 was released on 2007-08-04.
Licenses "AMPAS" and "ILM" must be added to ${PORTDIR}/licenses.
Created attachment 129282 [details]
media-libs/openexr/openexr-1.6.0.ebuild
Created attachment 129284 [details]
media-libs/ilmbase/ilmbase-1.0.0.ebuild
Created attachment 129285 [details, diff]
media-libs/ilmbase/files/ilmbase-1.0.0-asneeded.patch
Created attachment 129286 [details]
media-libs/ctl/ctl-1.4.0.ebuild
Created attachment 129287 [details]
media-libs/openexr_ctl/openexr_ctl-1.0.0.ebuild
Created attachment 129289 [details]
media-libs/openexr_viewers/openexr_viewers-1.0.0.ebuild
Created attachment 129291 [details, diff]
media-gfx/openexr_viewers/files/openexr_viewers-1.0.0-nvidia-automagic.patch
Created attachment 129325 [details]
media-libs/ilmbase/ilmbase-1.0.0.ebuild
Fixed typo.
Created attachment 129327 [details]
media-libs/openexr/openexr-1.6.0.ebuild
Fixed typo.
Created attachment 129328 [details]
media-libs/openexr_viewers/openexr_viewers-1.0.0.ebuild
Fixed typo.
Created attachment 129329 [details, diff]
kfile_OpenEXR.patch
Patch for kde-base/kdegraphics and kde-base/kdegraphics-kfile-plugins.
Gentoo KDE team, Please include patch from Comment #13 in kde-base/kdegraphics and kde-base/kdegraphics-kfile-plugins. New revisions aren't needed, because users, who have updated OpenEXR, will have to run revdep-rebuild, which will reemerge kdegraphics or kdegraphics-kfile-plugins. See https://bugs.kde.org/show_bug.cgi?id=148865. Vapier added ~sh keyword to OpenEXR 1.2.2-r2 and 1.4.0a, so for each ebuild please run: sed -i -e "s/~sparc/~sh ~sparc/" (In reply to comment #13) > kfile_OpenEXR.patch > > Patch for kde-base/kdegraphics and kde-base/kdegraphics-kfile-plugins. I think that this patch may be named kdegraphics-kfile-plugins-3.5.7-openexr-1.6.0.patch. I've extensively and successfully tested the patch against both older and the new version of openexr and as it comes directly from upstream, I've applied it. kde is done here. Comment on attachment 129329 [details, diff]
kfile_OpenEXR.patch
Applied.
Media-Video Herd, Please continue with adding of these files to the tree. Remember about sed -i -e "s/~sparc/~sh ~sparc/". Created attachment 129737 [details, diff]
media-libs/openexr/openexr-1.6.0.ebuild
Created attachment 129738 [details, diff]
media-libs/ilmbase/ilmbase-1.0.0.ebuild
Created attachment 129739 [details, diff]
media-libs/ctl/ctl-1.4.0.ebuild
Created attachment 129740 [details, diff]
media-libs/openexr_ctl/openexr_ctl-1.0.0.ebuild
Fixed typo in dependencies.
Created attachment 129741 [details, diff]
media-libs/openexr_viewers/openexr_viewers-1.0.0.ebuild
Fixed typo in dependencies.
(In reply to comment #19) > Remember about sed -i -e "s/~sparc/~sh ~sparc/". Not relevant any more. Created attachment 130525 [details, diff]
media-libs/openexr/openexr-1.6.0.ebuild
"utils" -> "viewers".
Ok, first of all, thanks for the euiblds. I've been able to have them pass make check, that was probably a gcc bug.
So now here are a few remarks :
- ebuild header is not valid, header.txt states gpl v2 not v3. (running repoman full will tell you that)
- installing ctl with use=doc gives me those files :
/usr/share/doc/CTL-1.4.0/CtlManual.doc
/usr/share/doc/CTL-1.4.0/CtlManual.pdf
/usr/share/doc/ctl-1.4.0/CtlManual.pdf.bz2
so they're probably duplicate. (same applies to openexr & use doc, and probably others)
- please put in keywords only the one you have tested in case of new packages.
- please don't pdepend on another package unless absolutetly needed, openexr is intended to be a library so no need to force people to install viewers.
- are you sure openexr_viewers should go in media-libs category ?
(In reply to comment #27) > - ebuild header is not valid, header.txt states gpl v2 not v3. OK. I'm relicensing these ebuilds. > - installing ctl with use=doc gives me those files : > /usr/share/doc/CTL-1.4.0/CtlManual.doc > /usr/share/doc/CTL-1.4.0/CtlManual.pdf These were installed by `make install`. Fixed. > /usr/share/doc/ctl-1.4.0/CtlManual.pdf.bz2 I disabled useless compression. > - please put in keywords only the one you have tested in case of new > packages. OpenEXR was divided into IlmBase, OpenEXR and OpenEXR_Viewers. CTL and OpenEXR_CTL are realy new and OpenEXR_Viewers package depends on them, so I'm reducing KEYWORDS in case of CTL, OpenEXR_CTL, and OpenEXR_Viewers. After addition of these ebuilds to gentoo-x86 I can open a bug report concerning rekeywording of these 3 packages (CTL, OpenEXR_CTL, and OpenEXR_Viewers). > - please don't pdepend on another package unless absolutetly needed, openexr > is intended to be a library so no need to force people to install viewers. OK. Information about OpenEXR_Viewers will be displayed in pkg_postinst(). > - are you sure openexr_viewers should go in media-libs category ? OK. I moved OpenEXR_Viewers to media-gfx category. Created attachment 130727 [details]
media-libs/ilmbase/ilmbase-1.0.0.ebuild
Created attachment 130729 [details]
media-libs/openexr/openexr-1.6.0.ebuild
Created attachment 130731 [details]
media-libs/ctl/ctl-1.4.0.ebuild
Created attachment 130733 [details]
media-libs/openexr_ctl/openexr_ctl-1.0.0.ebuild
Created attachment 130734 [details]
media-libs/openexr_ctl/openexr_ctl-1.0.0.ebuild
Created attachment 130736 [details]
media-gfx/openexr_viewers/openexr_viewers-1.0.0.ebuild
hmm there are some things I had not seen at first : - please use eautoreconf from autotools.eclass for openexr_viewers - dont install the LICENSE file while installing docs, it's already installed. - I don't understand why you want to add 'ILM' license. Isn't it a BSD license ? - you replaced dodoc for cp -v, I tend to prefer dodoc or insinto + doins For the docs/examples that are now removed in the ebuild, I'd say leave them here and drop the useflag, if the build scripts do not allow to not install them, then imho we shouldn't try to be clever than upstream; and perhaps they prefer that the examples are always installed. (In reply to comment #35) > - dont install the LICENSE file while installing docs, it's already > installed. OK. Fixed. > - I don't understand why you want to add 'ILM' license. Isn't it a BSD > license? I don't know. I'm not lawyer. But I changed it to "BSD". > - you replaced dodoc for cp -v, I tend to prefer dodoc or insinto + doins OK. I will use insinto + doins. > For the docs/examples that are now removed in the ebuild, I'd say leave them > here and drop the useflag, if the build scripts do not allow to not install > them, then imho we shouldn't try to be clever than upstream; and perhaps > they prefer that the examples are always installed. "examples" USE flag is primarily used to control building of IlmImf example program by $(use_enable examples imfexamples). (In reply to comment #35) > - please use eautoreconf from autotools.eclass for openexr_viewers OK. Fixed. > For the docs/examples that are now removed in the ebuild, I'd say leave them > here and drop the useflag, if the build scripts do not allow to not install > them, then imho we shouldn't try to be clever than upstream Also see bug 111508. Created attachment 130839 [details]
media-libs/ilmbase/ilmbase-1.0.0.ebuild
Created attachment 130842 [details]
media-libs/openexr/openexr-1.6.0.ebuild
Created attachment 130844 [details]
media-libs/ctl/ctl-1.4.0.ebuild
Created attachment 130845 [details]
media-libs/openexr_ctl/openexr_ctl-1.0.0.ebuild
Created attachment 130847 [details]
media-gfx/openexr_viewers/openexr_viewers-1.0.0.ebuild
(In reply to comment #36) > > - I don't understand why you want to add 'ILM' license. Isn't it a BSD > > license? > > I don't know. I'm not lawyer. But I changed it to "BSD". Neither am I ;) But their web site says it's modified bsd license and it matches our BSD lincense ^^ and now they're in the tree, thanks a lot for your ebuilds and work there ! @archs : $ diff -u openexr-1.4.0a.ebuild openexr-1.6.0.ebuild | grep KEYWORD -KEYWORDS="alpha ~amd64 hppa ia64 ~mips ppc ~ppc64 ~sh ~sparc x86" +KEYWORDS="~amd64 ~x86" Please rekeyword media-libs/openexr-1.6.0 and media-gfx/openexr_viewers-1.0.0 & depenendcies (media-libs/ctl media-libs/openexr_ctl media-libs/ilmbase), that's the split of openexr. I could have kept your keywords for ilmbase and openexr as they were present in previous openexr releases, but you'd have lost viewers features by doing this, so I prefer the whole split is keyworded as a whole ;) bah.. I had tested them on x86... sorry for the noise Marked ~hppa. ~ppc'd ~alpha/~ia64 done added ~ppc64 ~sparc done Gentoo/BSD Team, You can consider addition of ~x86-fbsd keyword to: media-libs/ctl-1.4.1 media-libs/openexr_ctl-1.0.1 media-gfx/openexr_viewers-1.0.1 (In reply to comment #51) > Gentoo/BSD Team, > You can consider addition of ~x86-fbsd keyword to: > media-libs/ctl-1.4.1 > media-libs/openexr_ctl-1.0.1 > media-gfx/openexr_viewers-1.0.1 > all done now mips and sh will just lose openexr in 30 days entirely if this isn't handled. mips just lost openexr entirely. sh is handled in bug 207663. Reopening to fix resolution. |