Bug 188889 – media-libs/libzzub - changes in ebuild

• Product: Gentoo Linux
• Status: RESOLVED WONTFIX

[Description Federico Ferri (RETIRED) 2007-08-14 19:29:00 UTC]

I updated aldrin and libzzub ebuilds cleaning deps, adding USE switches, doing trivial changes.

ebuilds pulls sources from SVN (cause lot of cool features are going to be added in the next release, and I can't wait for it! ;)) but reverting to release tarballs it's about deleting 3 lines and adding SRC_URI

also it would be nice to have those SVN ebuilds (hardmasked) in portage

[Comment 1 Federico Ferri (RETIRED) 2007-08-14 19:30:09 UTC]

Created attachment 128092 [details]
media-libs/libzzub/libzzub-9999.ebuild

[Comment 2 Jakub Moc (RETIRED) 2007-08-14 19:32:34 UTC]

We are not adding live SVN stuff, sorry. If you have fixes for current ebuilds, attach a unified diff here. Thanks.

http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=3&chap=1#doc_chap3

[Comment 3 Federico Ferri (RETIRED) 2007-08-14 19:43:29 UTC]

Created attachment 128096 [details, diff]
zzub.diff

as you want, sir

[Comment 4 Federico Ferri (RETIRED) 2007-08-14 19:44:51 UTC]

the attached diff is for actual ebuild in portage

[Comment 5 Federico Ferri (RETIRED) 2007-08-16 13:41:09 UTC]

I got some feedback from the author:

+	CF="$CF BMPCCM=$(use bmp-ccm && echo yes || echo no)"

the bmp-ccm USE flag can be removed, as the author told me it only for windows, and actually fails compiling on Gentoo Linux

+	CF="$CF BUZZ2ZZUB=$(use buzz2zzub && echo yes || echo no)"

the buzz2zzub flag doesn't do anything on Linux and can be removed


feedback from me:

actually I have built it fine with those use flags:
USE="alsa buzz2zzub dssi jack ladspa lunar mp3 oss sndfile sse zzub-module zzub-stream -bmp-ccm -debug -no-signature -sse2"

(although zzub-module and zzub-stream flags are highy experimental and do not add functionality yet)

[Comment 6 Federico Ferri (RETIRED) 2007-08-17 15:46:45 UTC]

Created attachment 128402 [details]
media-libs/libzzub/libzzub-0.2.3.ebuild

fixed some stuff:
* fixed CFLAGS handling in SConstruct
* SSE,SSE2 (scons) adds only the CFLAGS - removed from USE flags

[Comment 7 Federico Ferri (RETIRED) 2007-08-17 15:47:08 UTC]

Created attachment 128403 [details, diff]
media-libs/libzzub/files/scons.diff

[Comment 8 Federico Ferri (RETIRED) 2007-08-17 16:43:16 UTC]

Created attachment 128409 [details]
media-libs/libzzub/libzzub-0.2.3.ebuild

OUPS! I wasn't careful enough to check that SConstruct re-added SSE flags with an automatic check.

I prefer to leave the user choice thru CFLAGS (but also warning him about the possible performance loss)

[Comment 9 Federico Ferri (RETIRED) 2007-08-17 16:43:45 UTC]

Created attachment 128410 [details, diff]
media-libs/libzzub/files/scons.diff

removed automatic sse check

[Comment 10 Federico Ferri (RETIRED) 2007-08-17 17:01:32 UTC]

about the waveform problem:
it should be clearly a gcc bug (I tested with gcc-4.1.3 pre) but would be a pain to exploit and demonstrate...

if the -fno-tree-pre isn't enough I think one has to try directly with -O1, that's guaranteed to work

HTH

[Comment 11 Federico Ferri (RETIRED) 2007-08-19 18:58:00 UTC]

Created attachment 128604 [details]
media-libs/libzzub/libzzub-0.2.3.ebuild

removed that `grep` crap and used more nice is-flag{,q} function
(also checks for -O3,-O2,-Os and replaces it with -O1)

clean up

this should be the last update

[Comment 12 Federico Ferri (RETIRED) 2007-08-19 21:46:31 UTC]

after asking for a review on #gentoo-dev-help

zlin suggests removing the ewarns and epauses, and directly doing:

  replace-flags -O? -O1

also he suggests to just append -fno-tree-pre (there's no need to filter)

[Comment 13 Hanno Böck 2012-01-22 17:09:53 UTC]

package has been removed from tree

[Comment 14 Hanno Böck 2012-01-22 17:10:05 UTC]

done