Summary: | etc-update does not check its input | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Brant Gurganus <brant> |
Component: | [OLD] Unspecified | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | cla |
Priority: | High | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 216231 |
Description
Brant Gurganus
2007-08-14 02:50:14 UTC
It's better than it used to be (bug 143881). I suppose we can stop trying to read it into an integer type in order to avoid that error all together. I'd have to be more familiar with the language etc-update is written in, but the data type isn't the problem. It does need to be an integer, unless non-integer input is expected at some point. In my brief testing, it seemed like the select syntax of bash was more robust. Am I correct there? Would select be better? Isn't it fixed already? :) In svn r12053 I've fixed it to show a more human readable error message, like this: Value '1y' is not valid. Please enter an integer value: (In reply to comment #3) > Isn't it fixed already? :) Well, it was fixed in the sense that the program would continue to run. However, the error message was not very good. This is fixed in 2.1.6_rc1 and 2.2_rc16. |