Bug 188057

Summary:	sys-apps/module-init-tools doesn't deal with multiple module option lines in /etc/modules.conf
Product:	Gentoo Linux	Reporter:	Andrew Hurst <a.hurst>
Component:	[OLD] Core system	Assignee:	X11 External Driver Maintainers <x11-drivers>
Status:	RESOLVED INVALID
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Andrew Hurst 2007-08-07 23:07:41 UTC

New nvdia-drivers' module config file (/etc/modules.d/nvidia) contains multiple lines of the form 'options nvidia NVoption_1 NVoption_2 ...'

When update-modules processes this, /etc/modules.conf ends up with multiple lines as above.

Now when generate-modprobe.conf runs over thie /etc/modules.conf, only the last 'options nvidia ...' line is output (to /etc/modprobe.conf), missing for example 'options nvidia NVreg_EnableAGPSBA=1'

Reproducible: Always

Steps to Reproduce:
1. emerge latest nvidia-drivers, module-init-tools
2. set several 'options nvidia ...' lines on /etc/modules.d/nvidia
3. run update-modules, generate-modprobe.conf
4. observe only the last 'options nvidia ...' line in /etc/modprobe.conf



Expected Results:  
all the nvidia options to be merged into one line for generate-modprobe.conf

Does the gentoo module system support switching over completely to /etc/modprobe.d/, /etc/modprobe.conf, /etc/modprobe.devfs yet?

Comment 1 Andrew Hurst 2007-08-08 00:00:14 UTC

The alternative is that update-modules and generate-modprobe.conf are not designed to handle multiple 'options ...' lines for a single module:

I.e. all options for each module (/etc/modules.d/*) should go on a single line?

Comment 2 Doug Goldstein (RETIRED) gentoo-dev

2007-08-08 15:58:07 UTC

They are documented lines. The only real line exists at the bottom. It's up to you to read the documentation and build your own finalized line at the bottom containing all the options you need. Multiple lines do not exist in the raw Portage version of the file.

Comment 3 Andrew Hurst 2007-08-08 16:37:39 UTC

Doug,
I'm sorry if this is enirely my own fault:  I didn'y realise only one module option line was allowed.
I think the nvidia example module config file should be changed to make this clear, instead of inviting the user to 'uncomment the following line to enable AGP SBA/FW'

I don't remember ever being warned, or seeing in the docs that module options should all go on one line.  Could update-modules print a warning if >1 options lines referencing the same module are found?

Comment 4 Jakub Moc (RETIRED) gentoo-dev

2007-08-09 06:31:09 UTC

*** Bug 188182 has been marked as a duplicate of this bug. ***