Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 187405

Summary: dev-php[45]/pecl-geoip (new ebuild)
Product: Gentoo Linux Reporter: Olivier Hill <olivier.hill>
Component: New packagesAssignee: PHP Bugs <php-bugs>
Status: RESOLVED FIXED    
Severity: enhancement Keywords: EBUILD, InVCS
Priority: Lowest    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://pecl.php.net/geoip
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: dev-php[4-5]/pecl-geoip/

Description Olivier Hill 2007-08-01 17:28:34 UTC
Simple ebuild for PECL GeoIP module.

Reproducible: Always

Steps to Reproduce:
Comment 1 Olivier Hill 2007-08-01 17:29:17 UTC
Created attachment 126632 [details]
dev-php[4-5]/pecl-geoip/
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-08-14 14:42:53 UTC
Added to PHP overlay [1] now, please test. Unlikely to get to the official tree anytime soon, see the ebuild ewarns and provided README, additionally upstream development seems to have stalled.

[1] http://overlays.gentoo.org/proj/php/browser/experimental/dev-php5/pecl-geoip
Comment 3 Olivier Hill 2007-08-14 15:14:53 UTC
Which upstream, libgeoip or PECL geoip? I'm the maintainer of the PECL bindings, and since we do not receive any bug reports, we have no need to release another version.

I'll provide the other files you need.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-08-14 19:52:50 UTC
(In reply to comment #3)
> Which upstream, libgeoip or PECL geoip? I'm the maintainer of the PECL
> bindings, and since we do not receive any bug reports, we have no need to
> release another version.

Well, maybe you should update your README so that it doesn't moan about segfaults and no clue how to use GeoIP API then? Kinda discouraging lots of people. :)

<snip>
Since I'm very new to the GeoIP API I dont know how to specify properly the database file when calling the functions; first trial worked with geoip_database_info(), but next did not with geoip_country_code_by_name() - and again segfault...  So for now I would like to leave the proper calls of the GeoIP lib to someone with more insigt - I did the PHP stuff where I'm a bit more familar with....
</snip>
Comment 5 Olivier Hill 2007-08-14 20:18:35 UTC
You are absolutely right..

I didn't write that part, that was the README file sitting on Sourgeforge before I took the code and put it on PECL. And yes it had many segfaults, most of them because freeing of resources was not done in the proper order.

I have removed that part of the README on CVS, and rolled a stable release (which had to be 1.0.0). Should have removed that part of the README way before, didn't even noticed it was still there.

I have been using that PECL extension on various website without any problems and I feel it is stable. The only reason I have created the ebuild with ARCH="~" was that new ebuilds should be masked for at least 2 weeks and I wanted to respect that policy.

Thank you for your comments.
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-08-14 20:35:15 UTC
Heh; well... poke us when 1.0 is out, I'll bump it and move the ebuild to testing overlay branch then :)
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-08-15 07:19:32 UTC
(In reply to comment #6)
> I'll bump it and move the ebuild to testing overlay branch then :)

And done, thanks for quick response. ;)

http://overlays.gentoo.org/proj/php/browser/testing/dev-php5/pecl-geoip
Comment 8 Olivier Hill 2007-08-15 12:29:05 UTC
Once again, thank you for your work :)
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2007-08-30 13:03:07 UTC
InCVS now, enjoy!