Summary: | app-arch/lha feature disabled because of MinGW on Cygwin??? | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | John R. Graham <john_r_graham> |
Component: | Current packages | Assignee: | Mamoru KOMACHI (RETIRED) <usata> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ssuominen |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 184560 | ||
Attachments: |
New autotools magic to detect problematic environment.
New ebuild. Slightly cleaner new ebuild. Yet cleaner ebuild, with the help of the Gentoo Sunrise team. More cleanup of the the ebuild with the help of drac from Gentoo Sunrise. |
Description
John R. Graham
2007-07-11 00:43:00 UTC
Created attachment 124497 [details, diff]
New autotools magic to detect problematic environment.
Created attachment 124499 [details]
New ebuild.
This bug breaks app-backup//flexbackup's lha archive mode. Created attachment 124542 [details]
Slightly cleaner new ebuild.
Left in one spurious line of commented out code.
Created attachment 124977 [details]
Yet cleaner ebuild, with the help of the Gentoo Sunrise team.
Cleanups based on guidance from the Gentoo Sunrise folks: Use autotools eclass, include RDEPEND="" for documentation, include a message on die for emake, use ${P} in patch file name.
Not included or implemented in any way was the suggestion that renaming the ebuild from "lha-114i-r7" to "lha-1.14i-r7" would more closely match the upstream tarball and would allow MY_P to simplify from "${PN}-1.14i-ac20050924p1" to "${P}-ac20050924p1". I think this would cause "upgrade" issues because, according to the version comparison rules, "114i" > "1.14i".
Created attachment 125637 [details]
More cleanup of the the ebuild with the help of drac from Gentoo Sunrise.
* Use fresh ebuild header from /usr/portage/header.txt.
* Quote ${WORKDIR} properly.
* Eliminate unnecessary doc file 00readme.autoconf from install. File is
merely documentation of the configure script options and is mostly in
Japanese anyway.
Fixed in -r7, thanks. Going to leave this open so that, when usata comes back, he can (hopefully) forward it to upstream. (Upstream site is in Japanese.) - John (In reply to comment #8) > Going to leave this open so that, when usata comes back, he can (hopefully) > forward it to upstream. (Upstream site is in Japanese.) He's retired, you'll have to do it yourself. |