Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 184560

Summary: app-backup/flexbackup fails to back up targets with spaces in their names in some modes
Product: Gentoo Linux Reporter: John R. Graham <john_r_graham>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 184911    
Bug Blocks:    
Attachments: Patch fixes issues with rsync and cpio (copy) modes of FlexBackup.
New ebuild that applies the new patch (and all the old ones, too).
Patch now fixes all backup modes.
New patch now updates man pages.

Description John R. Graham gentoo-dev 2007-07-08 03:10:57 UTC
Spaces in file names are evil, but, alas, a fact of life.  FlexBackup acts as the front-end for the traditional--and not so traditional--*nix archiving tools, letting you choose your favorite archiving tool from a pretty comprehensive list:  afio, dump, tar, cpio (archive mode), star, pax, zip, lha, ar, shar, rsync, and cpio (copy mode).  It's author has handled quoting and/or escaping for *most* of those, but it's missing in some places where a space-containing file name may appear is just not complete.

There are issues with FlexBackup's use of the following archiving tools:  ar, rsync, cpio (copy mode), and lha.  I've got preliminary fixes for rsync and cpio (copy mode).  The issues with ar seem more fundamental right now, but I'm still looking at it and lha.

I'm attaching preliminary fixes so that others can test.  Not ready for the tree yet.

- John
Comment 1 John R. Graham gentoo-dev 2007-07-08 03:40:32 UTC
Created attachment 124205 [details, diff]
Patch fixes issues with rsync and cpio (copy) modes of FlexBackup.
Comment 2 John R. Graham gentoo-dev 2007-07-08 03:42:07 UTC
Created attachment 124206 [details]
New ebuild that applies the new patch (and all the old ones, too).
Comment 3 John R. Graham gentoo-dev 2007-07-11 13:24:28 UTC
Created attachment 124557 [details, diff]
Patch now fixes all backup modes.

Fixed lha and ar,  Had to fix a bug in lha to get it working, so a dependency on that bug was added to this bug.  Documentation still needs to be updated, as well.
Comment 4 John R. Graham gentoo-dev 2007-07-11 17:21:55 UTC
Comment on attachment 124557 [details, diff]
Patch now fixes all backup modes.

Should've been marked as a patch.
Comment 5 John R. Graham gentoo-dev 2007-07-19 01:46:05 UTC
Created attachment 125301 [details, diff]
New patch now updates man pages.
Comment 6 John R. Graham gentoo-dev 2007-07-24 11:09:47 UTC
This is now in Portage as flexbackup-1.2.1-r6 thanks to genstef and the Gentoo Sunrise team.

- John