| Summary: | nvidia-drivers-100.14.* fix to install the menu item and icon for nvidia-settings | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Robert Golding <robert.golding> |
| Component: | New packages | Assignee: | X11 External Driver Maintainers <x11-drivers> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | brebs, ed |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
The Gentoo devs forgot to populate /usr/portage/x11-drivers/nvidia-drivers/files/ with nvidia-settings.{png,desktop}
doicon and domenu in /usr/portage/eclass/eutils.eclass are far too fault-tolerant, meaning that the "|| die" sanity protections in the ebuild are useless.
The BASH code should *not* be skipping over these errors.
yeah trapni committed these ebuilds without all the necessary files. (In reply to comment #2) > yeah trapni committed these ebuilds without all the necessary files. > I just retried the fix by only copying the two files (nvidia-settings.{png,desktop} to x11-drivers/nvidia-drivers/files and didn't patch the ebuild, just did a digest. Worked well. Can the dev please populate the files dir as noted above? it's a masked ebuild that's under development. minor issue in the grand scheme of things. it will be fixed shortly. > it's a masked ebuild that's under development. minor issue in the grand scheme
> of things. it will be fixed shortly.
Stop being so damned mysterious. State what you're up to, and you might actually get some *help*.
I apologize. We were debating some security issues as well as a new approach to the nvidia-drivers. Also I've been completely slammed outside of Gentoo (moving, buying furniture,etc) I wanted to just commit everything at once completely done but you're right. I need to work with everyone a bit. I'm committing a snapshot ebuild that fixes a couple of bugs. I know this ebuild works since I've tested it and I'm using it. More changes will come but I haven't tested those too well. Can we have building nvidia-settings be optional? (In reply to comment #7) > Can we have building nvidia-settings be optional? Bug 182622. Please saerch before spamming unrelated bugs. This was fixed. |
When I first emerged the 100 series of nvidia-drivers (which include the nvidia-settings) the emerge didn't install the icon or desktop/menu files. I patched the ebuild; // ## usr/portage/x11-drivers/nvidia-drivers/nvidia-drivers-100.14.11.ebuild patch @@ -286,6 +286,6 @@ # Install icon and .desktop entry - doicon "${FILESDIR}/nvidia-settings.png" || die "doicon" - domenu "${FILESDIR}/nvidia-settings.desktop" || die "domenu" + doicon "${FILESDIR}/icon/nvidia-settings.png" || die "doicon" + domenu "${FILESDIR}/icon/nvidia-settings.desktop" || die "domenu" doman doc/nvidia-settings.1 || die // and copied the 'files/icon' dir from media-video/nvidia-settings to x11-drivers/nvidia-drivers. Reproducible: Always Steps to Reproduce: 1. patch nvidia-drivers-100.* as per above 2. cp -pR /usr/portage/media-video/nvidia-settings/files/icon /usr/portage/x11-drivers/nvidia-drivers/files/ 3. ebuild /usr/portage/x11-drivers/nvidia-drivers/nvidia-drivers-100.14.11.ebuild digest 4. emerge nvidia-drivers Actual Results: Now have the menu item for 'NVIDIA X Server Settings' with icon Expected Results: nvidia-settings to be added to menu with icon I hand edited the ebuild for the patch as I am not comfortable with making diff/patch files. This has worked with both 100.14.09 and 100.14.11.